[PATCH] D72494: [clangd] Fix targetDecl() on certain usage of ObjC properties.

ilya-biryukov requested changes to this revision. ilya-biryukov added a comment. This revision now requires changes to proceed. Could you also add a test (and possibly support this in the visitors) for `findExplicitReferences`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72494: [clangd] Fix targetDecl() on certain usage of ObjC properties.

sammccall created this revision. sammccall added reviewers: dgoldman, kadircet. Herald added subscribers: cfe-commits, usaxena95, jfb, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. ilya-biryukov requested changes to this revision. ilya-biryukov added a comment. This rev

[PATCH] D72494: [clangd] Fix targetDecl() on certain usage of ObjC properties.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61742 tests passed, 0 failed and 780 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D72494: [clangd] Fix targetDecl() on certain usage of ObjC properties.

sammccall added a comment. In D72494#1813719 , @ilya-biryukov wrote: > Could you also add a test (and possibly support this in the visitors) for > `findExplicitReferences`? I've written tests, but it doesn't work and it's not obvious to me yet how to

[PATCH] D72494: [clangd] Fix targetDecl() on certain usage of ObjC properties.

sammccall added a comment. In D72494#1813875 , @sammccall wrote: > In D72494#1813719 , @ilya-biryukov > wrote: > > > Could you also add a test (and possibly support this in the visitors) for > > `findExplicitRefer

[PATCH] D72494: [clangd] Fix targetDecl() on certain usage of ObjC properties.

kadircet accepted this revision. kadircet added a comment. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72494/new/ https://reviews.llvm.org/D72494 ___ cfe-commits mailing list cfe-commit

[PATCH] D72494: [clangd] Fix targetDecl() on certain usage of ObjC properties.

dgoldman accepted this revision. dgoldman added a comment. LGMT, thanks for fixing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72494/new/ https://reviews.llvm.org/D72494 ___ cfe-commits mailing list

[PATCH] D72494: [clangd] Fix targetDecl() on certain usage of ObjC properties.

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit rG4c5a4514d145: [clangd] Fix targetDecl() on certain usage of ObjC properties. (authored by sammccall). Changed prior to