[PATCH] D72508: [clangd] Support pseudo-obj expr, opaque values, and property references in findExplicitReferences()

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62195 tests passed, 0 failed and 815 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72508: [clangd] Support pseudo-obj expr, opaque values, and property references in findExplicitReferences()

This revision was automatically updated to reflect the committed changes. Closed by commit rGf4871ead55f5: [clangd] Support pseudo-obj expr, opaque values, and property references in… (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72508: [clangd] Support pseudo-obj expr, opaque values, and property references in findExplicitReferences()

sammccall updated this revision to Diff 240809. sammccall marked 4 inline comments as done. sammccall added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72508/new/ https://reviews.llvm.org/D72508 Files:

[PATCH] D72508: [clangd] Support pseudo-obj expr, opaque values, and property references in findExplicitReferences()

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:794 +// Not clear why the source expression is skipped by default... +return RecursiveASTVisitor::TraverseStmt(OVE->getSourceExpr()); + } Should this be done by

[PATCH] D72508: [clangd] Support pseudo-obj expr, opaque values, and property references in findExplicitReferences()

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62194 tests passed, 1 failed and 815 were skipped. failed: libc++.std/thread/thread_mutex/thread_mutex_requirements/thread_mutex_requirements_mutex/thread_mutex_recursive/try_lock.pass.cpp {icon check-circle

[PATCH] D72508: [clangd] Support pseudo-obj expr, opaque values, and property references in findExplicitReferences()

sammccall added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:624 + /*IsDecl=*/false, + // Select the getter, setter, or @property depending on the call. + explicitReferenceTargets(DynTypedNode::create(*E), {})});

[PATCH] D72508: [clangd] Support pseudo-obj expr, opaque values, and property references in findExplicitReferences()

sammccall updated this revision to Diff 240378. sammccall marked 5 inline comments as done. sammccall added a comment. more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72508/new/ https://reviews.llvm.org/D72508 Files:

[PATCH] D72508: [clangd] Support pseudo-obj expr, opaque values, and property references in findExplicitReferences()

dgoldman requested changes to this revision. dgoldman added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/clangd/FindTarget.cpp:624 + /*IsDecl=*/false, + // Select the getter, setter, or @property depending on the

[PATCH] D72508: [clangd] Support pseudo-obj expr, opaque values, and property references in findExplicitReferences()

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts :

[PATCH] D72508: [clangd] Support pseudo-obj expr, opaque values, and property references in findExplicitReferences()

sammccall created this revision. sammccall added reviewers: ilya-biryukov, dgoldman. Herald added subscribers: cfe-commits, usaxena95, kadircet, jfb, arphaman, jkorous, MaskRay. Herald added a project: clang. sammccall added a parent revision: D72494: [clangd] Fix targetDecl() on certain usage

[PATCH] D72508: [clangd] Support pseudo-obj expr, opaque values, and property references in findExplicitReferences()

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:570 auto AST = TU.build(); +EXPECT_THAT(AST.getDiagnostics(), ::testing::IsEmpty()) << Code; For