[PATCH] D72531: Set traversal explicitly where needed in tests

This revision was automatically updated to reflect the committed changes. Closed by commit rGa30d411629d5: Set traversal explicitly where needed in tests (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72531/new/ https://re

[PATCH] D72531: Set traversal explicitly where needed in tests

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/unittests/Tooling/StencilTest.cpp:63 ASTContext &Context = AstUnit->getASTContext(); - auto Matches = ast_matchers::match(wrapMatche

[PATCH] D72531: Set traversal explicitly where needed in tests

steveire marked an inline comment as done. steveire added inline comments. Comment at: clang/unittests/Tooling/StencilTest.cpp:63 ASTContext &Context = AstUnit->getASTContext(); - auto Matches = ast_matchers::match(wrapMatcher(Matcher), Context); + auto Matches = ast_matcher

[PATCH] D72531: Set traversal explicitly where needed in tests

aaron.ballman added inline comments. Comment at: clang/unittests/Tooling/StencilTest.cpp:63 ASTContext &Context = AstUnit->getASTContext(); - auto Matches = ast_matchers::match(wrapMatcher(Matcher), Context); + auto Matches = ast_matchers::match( + traverse(ast_type_tra

[PATCH] D72531: Set traversal explicitly where needed in tests

steveire marked an inline comment as done. steveire added inline comments. Comment at: clang/unittests/Tooling/StencilTest.cpp:63 ASTContext &Context = AstUnit->getASTContext(); - auto Matches = ast_matchers::match(wrapMatcher(Matcher), Context); + auto Matches = ast_matcher

[PATCH] D72531: Set traversal explicitly where needed in tests

aaron.ballman added a comment. In D72531#1845686 , @shafik wrote: > I was looking at the changes to `ASTImporterTest.cpp` and it not obvious to > me how you determined where it was needed. Some of the changes were reasonably obvious to me because they i

[PATCH] D72531: Set traversal explicitly where needed in tests

steveire updated this revision to Diff 263540. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72531/new/ https://reviews.llvm.org/D72531 Files: clang/unittests/AST/ASTImporterTest.cpp clang/unittests/AST/SourceL

[PATCH] D72531: Set traversal explicitly where needed in tests

shafik added a comment. I was looking at the changes to `ASTImporterTest.cpp` and it not obvious to me how you determined where it was needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72531/new/ https://reviews.llvm.org/D72531

[PATCH] D72531: Set traversal explicitly where needed in tests

steveire updated this revision to Diff 240841. steveire added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72531/new/ https://reviews.llvm.org/D72531 Files: clang/unittests/AST/ASTImporterTest.cpp clang/unittests/AST/SourceL

[PATCH] D72531: Set traversal explicitly where needed in tests

steveire updated this revision to Diff 237418. steveire added a comment. Fix case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72531/new/ https://reviews.llvm.org/D72531 Files: clang/unittests/AST/ASTImporterTest.cpp clang/unittests/AST/Sourc

[PATCH] D72531: Set traversal explicitly where needed in tests

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a reviewer: shafik. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72531 Files: clang/unittests/AST/ASTImporterTest.cpp