[PATCH] D72717: [CMake] Disable libc++ filesystem tests in CrossWinToARMLinux cache file

broadwaylamb planned changes to this revision. broadwaylamb added a comment. In D72717#1848509 , @ldionne wrote: > It's weird to mix Clang and libc++ test options because they test > fundamentally different things. But I don't mind about this patch since

[PATCH] D72717: [CMake] Disable libc++ filesystem tests in CrossWinToARMLinux cache file

ldionne added a comment. It's weird to mix Clang and libc++ test options because they test fundamentally different things. But I don't mind about this patch since it doesn't touch libc++ directly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7271

[PATCH] D72717: [CMake] Disable libc++ filesystem tests in CrossWinToARMLinux cache file

vvereschaka added a comment. > You mean, instead of ninja check-cxx just invoke LIT directly and pass this > argument? No, a little bit different. Probably we need something like 'LIBCXX_LLVM_LIT_ARGS` and pass the LIT arguments into the libc++ tests through that kind of parameter (and most li

[PATCH] D72717: [CMake] Disable libc++ filesystem tests in CrossWinToARMLinux cache file

broadwaylamb added a comment. In D72717#1824858 , @vvereschaka wrote: > I think it is optimal to pass this parameter directly in the builder > configuration only for libcxx as '-DLLVM_LIT_ARGS="--param > enable_filesystem=False"'. You mean, instead of

[PATCH] D72717: [CMake] Disable libc++ filesystem tests in CrossWinToARMLinux cache file

vvereschaka added a comment. May be just keep a note in the comments that this lit parameter is required for the remote libcxx tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72717/new/ https://reviews.llvm.org/D72717 _

[PATCH] D72717: [CMake] Disable libc++ filesystem tests in CrossWinToARMLinux cache file

vvereschaka added a comment. Hi Sergej, as far as I understood '--param enable_filesystem=False' argument is libc++ specific, but we pass those parameters to all the library tests. I think it is optimal to pass this parameter directly in the builder configuration only for libcxx as '-DLLVM_LIT_

[PATCH] D72717: [CMake] Disable libc++ filesystem tests in CrossWinToARMLinux cache file

broadwaylamb created this revision. broadwaylamb added reviewers: aorlov, vvereschaka, andreil99. Herald added subscribers: cfe-commits, ldionne, kristof.beyls, mgorny. Herald added a reviewer: EricWF. Herald added a project: clang. `filesystem` tests are not yet supported when running tests on a