[PATCH] D72781: [Matrix] Add __builtin_matrix_column_load to Clang.

This revision was automatically updated to reflect the committed changes. Closed by commit rG934bcaf10b57: [Matrix] Add __builtin_matrix_column_load to Clang. (authored by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72781/new/ https://revi

[PATCH] D72781: [Matrix] Add __builtin_matrix_column_load to Clang.

fhahn updated this revision to Diff 271613. fhahn added a comment. Rebased after recent parent patches landed. Will commit shortly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72781/new/ https://reviews.llvm.org/D72781 Files: clang/include/cla

[PATCH] D72781: [Matrix] Add __builtin_matrix_column_load to Clang.

fhahn added a comment. In D72781#2084077 , @rjmccall wrote: > LGTM. Thank you very much again John! This patch is pending on a few smallish improvements to the load/store intrinsics (D81472 ) and I'll land once that one

[PATCH] D72781: [Matrix] Add __builtin_matrix_column_load to Clang.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/include/clang/Sema/Sema.h:12126 + ExprResult SemaBuiltinMatrixColumnMajorLoadOverload(CallExpr *TheCall, +

[PATCH] D72781: [Matrix] Add __builtin_matrix_column_load to Clang.

fhahn updated this revision to Diff 269556. fhahn marked 2 inline comments as done. fhahn added a comment. Adjust naming as suggested, pass through volatile flag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72781/new/ https://reviews.llvm.org/D72

[PATCH] D72781: [Matrix] Add __builtin_matrix_column_load to Clang.

fhahn marked 3 inline comments as done. fhahn added inline comments. Comment at: clang/include/clang/Sema/Sema.h:12126 + ExprResult SemaBuiltinMatrixColumnMajorLoadOverload(CallExpr *TheCall, + ExprResult CallResult); --

[PATCH] D72781: [Matrix] Add __builtin_matrix_column_load to Clang.

rjmccall added inline comments. Comment at: clang/include/clang/Sema/Sema.h:4708 + /// conversion. + ExprResult tryConvertExprToTy(Expr *E, QualType Ty); + Please spell out "type" in the method name. Comment at: clang/include/clang/Sema/Sema.

[PATCH] D72781: [Matrix] Add __builtin_matrix_column_load to Clang.

fhahn marked 9 inline comments as done. fhahn added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10789 +def err_builtin_matrix_scalar_constant_unsigned_expr_arg: Error< + "%0 argument must be a constant unsigned integer expression">; + --

[PATCH] D72781: [Matrix] Add __builtin_matrix_column_load to Clang.

fhahn updated this revision to Diff 269378. fhahn marked 5 inline comments as done. fhahn added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Simplified code as suggested, check if matrix type extensions is enabled (and add test) and set align attribute for poi

[PATCH] D72781: [Matrix] Add __builtin_matrix_column_load to Clang.

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:15130 + +ElementTy.removeLocalConst(); +if (!ConstantMatrixType::isValidElementType(ElementTy)) { fhahn wrote: > rjmccall wrote: > > It's almost never correct to do "local" qualif

[PATCH] D72781: [Matrix] Add __builtin_matrix_column_load to Clang.

rjmccall added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10789 +def err_builtin_matrix_scalar_constant_unsigned_expr_arg: Error< + "%0 argument must be a constant unsigned integer expression">; + These are the same now.

[PATCH] D72781: [Matrix] Add __builtin_matrix_column_load to Clang.

fhahn marked 12 inline comments as done. fhahn added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:15107 + { +ExprResult PtrConv = DefaultLvalueConversion(PtrExpr); +if (PtrConv.isInvalid()) rjmccall wrote: > You should be doing `DefaultFu

[PATCH] D72781: [Matrix] Add __builtin_matrix_column_load to Clang.

fhahn updated this revision to Diff 269363. fhahn added a comment. Updated to - use DefaultFunctionArrayLvalueConversion for pointer conversion, use getAs subsequently - return Context.DependentTy if any part of the result matrix type is still type-dependent - add assertion & todo for volatile

[PATCH] D72781: [Matrix] Add __builtin_matrix_column_load to Clang.

rjmccall added a comment. `SubstTemplateTypeParmType` is a "sugar" type node, like a `typedef`, and code should generally be looking through it automatically by using `getAs` rather than `isa` / `dyn_cast`. Comment at: clang/lib/Sema/SemaChecking.cpp:15107 + { +ExprResul

[PATCH] D72781: [Matrix] Add __builtin_matrix_column_load to Clang.

fhahn updated this revision to Diff 269249. fhahn added a comment. Ping. Applied feedback from D72778 to this patch, improved tests, support conversions/placeholders. One thing I am not sure is how to properly handle template substitutions for the pointer expr

[PATCH] D72781: [Matrix] Add __builtin_matrix_column_load to Clang.

fhahn updated this revision to Diff 263879. fhahn edited the summary of this revision. fhahn added a comment. ping. Simplify code, extend tests. This should now be ready for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72781/new/ https://r

[PATCH] D72781: [Matrix] Add __builtin_matrix_column_load to Clang (WIP).

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : diff

[PATCH] D72781: [Matrix] Add __builtin_matrix_column_load to Clang (WIP).

fhahn created this revision. Herald added a subscriber: tschuett. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72781 Files: clang/include/clang/Basic/Builtins.def clang/include/clang/Sema/Sema.h clang/lib/CodeGen/CGBuiltin.cpp clang/lib/S