[PATCH] D72824: [X86] Add combination for fma and fneg on X86 under strict FP.

2020-01-28 Thread Pengfei Wang via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG3d1f0ce3b9f8: [X86] Add combination for fma and fneg on X86 under strict FP. (authored by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72824/new/

[PATCH] D72824: [X86] Add combination for fma and fneg on X86 under strict FP.

2020-01-27 Thread Craig Topper via Phabricator via cfe-commits
craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72824/new/ https://reviews.llvm.org/D72824 ___

[PATCH] D72824: [X86] Add combination for fma and fneg on X86 under strict FP.

2020-01-26 Thread Pengfei Wang via Phabricator via cfe-commits
pengfei updated this revision to Diff 240472. pengfei added a comment. Rebase and add vector instructions test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72824/new/ https://reviews.llvm.org/D72824 Files: llvm/lib/Target/X86/X86ISelLowering.c

[PATCH] D72824: [X86] Add combination for fma and fneg on X86 under strict FP.

2020-01-23 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. Are we missing tests for the vector instructions? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72824/new/ https://reviews.llvm.org/D72824 ___ cfe-commits mailing list cfe

[PATCH] D72824: [X86] Add combination for fma and fneg on X86 under strict FP.

2020-01-23 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon added a comment. In D72824#1835633 , @pengfei wrote: > In D72824#1835568 , @RKSimon wrote: > > > Add to isNegatibleForFree/getNegatedExpression as well? > > > We don't need to add them to isNegatibleForFree/

[PATCH] D72824: [X86] Add combination for fma and fneg on X86 under strict FP.

2020-01-23 Thread Pengfei Wang via Phabricator via cfe-commits
pengfei added a comment. In D72824#1835568 , @RKSimon wrote: > Add to isNegatibleForFree/getNegatedExpression as well? We don't need to add them to isNegatibleForFree/getNegatedExpression. We won't negate any FMA results by negative FMA instructions und

[PATCH] D72824: [X86] Add combination for fma and fneg on X86 under strict FP.

2020-01-23 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon added a comment. Add to isNegatibleForFree/getNegatedExpression as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72824/new/ https://reviews.llvm.org/D72824 ___ cfe-commits mailing list cf

[PATCH] D72824: [X86] Add combination for fma and fneg on X86 under strict FP.

2020-01-16 Thread Pengfei Wang via Phabricator via cfe-commits
pengfei updated this revision to Diff 238425. pengfei added a comment. Add FMA4 tests. Thanks @RKSimon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72824/new/ https://reviews.llvm.org/D72824 Files: llvm/lib/Target/X86/X86ISelLowering.cpp llv

[PATCH] D72824: [X86] Add combination for fma and fneg on X86 under strict FP.

2020-01-16 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon added a comment. FMA4 tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72824/new/ https://reviews.llvm.org/D72824 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D72824: [X86] Add combination for fma and fneg on X86 under strict FP.

2020-01-15 Thread Pengfei Wang via Phabricator via cfe-commits
pengfei created this revision. pengfei added reviewers: craig.topper, andrew.w.kaylor, uweigand, RKSimon, LiuChen3. pengfei added a project: LLVM. X86 has instructions to calculate fma and fneg at the same time. But we combine the fneg and fma only when fneg is the source operand under strict FP