[PATCH] D72825: [NFC] Fix options name typo

2020-01-16 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. > These three options may be used in other projects compiled by gcc. We can add them on demand. I don't see a rationale to add them preemptively. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72825/new/ https://reviews.llv

[PATCH] D72825: [NFC] Fix options name typo

2020-01-16 Thread Jim Lin via Phabricator via cfe-commits
Jim added a comment. It should be kept for compatibility. These three options may be used in other projects compiled by gcc. Clang should ignore it. https://gcc.gnu.org/onlinedocs/gcc/Optimize-Options.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D72825: [NFC] Fix options name typo

2020-01-16 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. Can we just delete the options? The misspelled options were added in rC214906 to work around https://clang.debian.net/status.php?version=3.4.2&key=UNKNOWN_ARG . Actually the `-ftree*` options were not used. Apparently our option name

[PATCH] D72825: [NFC] Fix options name typo

2020-01-16 Thread Jim Lin via Phabricator via cfe-commits
Jim created this revision. Jim added reviewers: efriedma, MaskRay. Herald added a project: clang. Herald added a subscriber: cfe-commits. Jim edited the summary of this revision. 1. -ftree_loop_im -> -ftree-loop-im 2. -ftree_loop_ivcanon -> -ftree-loop-ivcanon 3. -ftree_loop_linear -> -ftree-loop-