[PATCH] D72855: Make LLVM_APPEND_VC_REV=OFF affect clang, lld, and lldb as well.

2020-01-16 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. A very late follow-up to my question in D37272 :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72855/new/ https://reviews.llvm.org/D72855 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D72855: Make LLVM_APPEND_VC_REV=OFF affect clang, lld, and lldb as well.

2020-01-16 Thread Nico Weber via Phabricator via cfe-commits
thakis created this revision. thakis added a reviewer: rnk. Herald added a subscriber: mgorny. Herald added a project: LLVM. thakis added a comment. A very late follow-up to my question in D37272 :) When LLVM_APPEND_VC_REV=OFF is set, the current git hash is no

[PATCH] D72855: Make LLVM_APPEND_VC_REV=OFF affect clang, lld, and lldb as well.

2020-01-16 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: llvm/cmake/modules/LLVMConfig.cmake.in:81 +set(LLVM_APPEND_VC_REV "@LLVM_APPEND_VC_REV@") + This here should make the standalone build configs w

[PATCH] D72855: Make LLVM_APPEND_VC_REV=OFF affect clang, lld, and lldb as well.

2020-01-16 Thread Nico Weber via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGfb5fafb23cc2: Make LLVM_APPEND_VC_REV=OFF affect clang, lld, and lldb as well. (authored by thakis). Herald added projects: clang, LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION