[PATCH] D72860: [modules] Do not cache invalid state for modules that we attempted to load.

rsmith added inline comments. Comment at: clang/lib/Serialization/ModuleManager.cpp:183 // Get a buffer of the file and close the file descriptor when done. - Buf = FileMgr.getBufferForFile(NewModule->File, /*isVolatile=*/false); + Buf =

[PATCH] D72860: [modules] Do not cache invalid state for modules that we attempted to load.

vsapsai marked an inline comment as done. vsapsai added inline comments. Comment at: clang/lib/Serialization/ModuleManager.cpp:183 // Get a buffer of the file and close the file descriptor when done. - Buf = FileMgr.getBufferForFile(NewModule->File,

[PATCH] D72860: [modules] Do not cache invalid state for modules that we attempted to load.

dblaikie added inline comments. Comment at: clang/lib/Serialization/ModuleManager.cpp:183 // Get a buffer of the file and close the file descriptor when done. - Buf = FileMgr.getBufferForFile(NewModule->File, /*isVolatile=*/false); + Buf =

[PATCH] D72860: [modules] Do not cache invalid state for modules that we attempted to load.

vsapsai marked an inline comment as done. vsapsai added inline comments. Comment at: clang/lib/Serialization/ModuleManager.cpp:183 // Get a buffer of the file and close the file descriptor when done. - Buf = FileMgr.getBufferForFile(NewModule->File,

[PATCH] D72860: [modules] Do not cache invalid state for modules that we attempted to load.

dexonsmith added inline comments. Comment at: clang/lib/Serialization/ModuleManager.cpp:183 // Get a buffer of the file and close the file descriptor when done. - Buf = FileMgr.getBufferForFile(NewModule->File, /*isVolatile=*/false); + Buf =

[PATCH] D72860: [modules] Do not cache invalid state for modules that we attempted to load.

rsmith added inline comments. Comment at: clang/lib/Serialization/ModuleManager.cpp:183 // Get a buffer of the file and close the file descriptor when done. - Buf = FileMgr.getBufferForFile(NewModule->File, /*isVolatile=*/false); + Buf =

[PATCH] D72860: [modules] Do not cache invalid state for modules that we attempted to load.

This revision was automatically updated to reflect the committed changes. Closed by commit rG83f4c3af021c: [modules] Do not cache invalid state for modules that we attempted to load. (authored by vsapsai). Changed prior to commit: https://reviews.llvm.org/D72860?vs=238562=238668#toc

[PATCH] D72860: [modules] Do not cache invalid state for modules that we attempted to load.

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/Serialization/ModuleManager.cpp:183 // Get a buffer of the file and close the file descriptor when done. - Buf =

[PATCH] D72860: [modules] Do not cache invalid state for modules that we attempted to load.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61863 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72860: [modules] Do not cache invalid state for modules that we attempted to load.

vsapsai marked an inline comment as done. vsapsai added a comment. Anecdotal build time measurements before and after the change. First row is a clean build, subsequent rows are incremental builds. | Revision | Before change | After change | Change (after - before) | Relative change | |

[PATCH] D72860: [modules] Do not cache invalid state for modules that we attempted to load.

vsapsai created this revision. vsapsai added reviewers: bruno, dexonsmith. Herald added subscribers: cfe-commits, ributzka, jkorous. Herald added a project: clang. Partially reverts 0a2be46cfdb698fefcc860a56b47dde0884d5335 as it turned out to cause redundant module rebuilds in multi-process