[PATCH] D72867: [clangd] Support renaming designated initializers

This revision was automatically updated to reflect the committed changes. Closed by commit rG9f6d8de28ab6: [clangd] Support renaming designated initializers (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72867/new/

[PATCH] D72867: [clangd] Support renaming designated initializers

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/FindTarget.cpp:639 +void VisitDesignatedInitExpr(const DesignatedInitExpr *DIE) { + for (const

[PATCH] D72867: [clangd] Support renaming designated initializers

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62405 tests passed, 0 failed and 839 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72867: [clangd] Support renaming designated initializers

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:639 +void VisitDesignatedInitExpr(const DesignatedInitExpr *DIE) { + for (const DesignatedInitExpr::Designator : DIE->designators()) { +if (!D.isFieldDesignator())

[PATCH] D72867: [clangd] Support renaming designated initializers

kbobyrev updated this revision to Diff 242040. kbobyrev marked an inline comment as done. kbobyrev added a comment. Add tests for nested designated initializers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72867/new/

[PATCH] D72867: [clangd] Support renaming designated initializers

kbobyrev planned changes to this revision. kbobyrev marked an inline comment as done. kbobyrev added a comment. Going to deal with nested designated inits soon and update the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72867/new/

[PATCH] D72867: [clangd] Support renaming designated initializers

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:566 TU.ExtraArgs.push_back("-fno-delayed-template-parsing"); -TU.ExtraArgs.push_back("-std=c++17"); +

[PATCH] D72867: [clangd] Support renaming designated initializers

sammccall added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:639 +void VisitDesignatedInitExpr(const DesignatedInitExpr *DIE) { + for (const DesignatedInitExpr::Designator : DIE->designators()) { +if (!D.isFieldDesignator())

[PATCH] D72867: [clangd] Support renaming designated initializers

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61929 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72867: [clangd] Support renaming designated initializers

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61929 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72867: [clangd] Support renaming designated initializers

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 61928 tests passed, 1 failed and 783 were skipped. failed: libc++.std/thread/thread_mutex/thread_mutex_requirements/thread_sharedtimedmutex_requirements/thread_sharedtimedmutex_class/try_lock.pass.cpp {icon

[PATCH] D72867: [clangd] Support renaming designated initializers

kbobyrev updated this revision to Diff 238586. kbobyrev added a comment. Remove duplicated testt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72867/new/ https://reviews.llvm.org/D72867 Files: clang-tools-extra/clangd/FindTarget.cpp

[PATCH] D72867: [clangd] Support renaming designated initializers

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. kbobyrev updated this revision to Diff 238586. kbobyrev added a comment. Remove duplicated testt Clangd