[PATCH] D73236: [clang-tidy] Add clang-tidy headers to clang distribution

2020-01-23 Thread Dmitry Polukhin via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG301a437250b0: [clang-tidy] Add clang-tidy headers to clang distribution (authored by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73236/new

[PATCH] D73236: [clang-tidy] Add clang-tidy headers to clang distribution

2020-01-23 Thread Dmitry Polukhin via Phabricator via cfe-commits
DmitryPolukhin updated this revision to Diff 240037. DmitryPolukhin added a comment. remove `PATTERN ".svn" EXCLUDE` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73236/new/ https://reviews.llvm.org/D73236 Files: clang-tools-extra/clang-tidy/CMa

[PATCH] D73236: [clang-tidy] Add clang-tidy headers to clang distribution

2020-01-23 Thread Dmitry Polukhin via Phabricator via cfe-commits
DmitryPolukhin marked an inline comment as done. DmitryPolukhin added inline comments. Comment at: clang-tools-extra/clang-tidy/CMakeLists.txt:104 +PATTERN "*.h" +PATTERN ".svn" EXCLUDE +) alexfh wrote: > Is this still relevant? Perhaps no, but I stil

[PATCH] D73236: [clang-tidy] Add clang-tidy headers to clang distribution

2020-01-23 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG with an outstanding comment. Comment at: clang-tools-extra/clang-tidy/CMakeLists.txt:104 +PATTERN "*.h" +PATTERN ".svn" EXCLUDE +) Is this sti

[PATCH] D73236: [clang-tidy] Add clang-tidy headers to clang distribution

2020-01-23 Thread Dmitry Polukhin via Phabricator via cfe-commits
DmitryPolukhin updated this revision to Diff 239953. DmitryPolukhin added a comment. - removed DEPENDS Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73236/new/ https://reviews.llvm.org/D73236 Files: clang-tools-extra/clang-tidy/CMakeLists.txt I

[PATCH] D73236: [clang-tidy] Add clang-tidy headers to clang distribution

2020-01-22 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. This LGTM, but I'll give the clang-tidy developers some time to weigh in. Comment at: clang-tools-extra/clang-tidy/CMakeLists.txt:106 +) + add_custom_target(clang-tidy-headers DEPENDS clang-headers) + set_target_properties(clang-tidy-headers PROPE

[PATCH] D73236: [clang-tidy] Add clang-tidy headers to clang distribution

2020-01-22 Thread Dmitry Polukhin via Phabricator via cfe-commits
DmitryPolukhin updated this revision to Diff 239746. DmitryPolukhin added a comment. - added clang-tidy-header component Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73236/new/ https://reviews.llvm.org/D73236 Files: clang-tools-extra/clang-tidy/

[PATCH] D73236: [clang-tidy] Add clang-tidy headers to clang distribution

2020-01-22 Thread Dmitry Polukhin via Phabricator via cfe-commits
DmitryPolukhin updated this revision to Diff 239741. DmitryPolukhin added a comment. Herald added a subscriber: mgehre. - moved header installation to clang-tidy cmake file Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73236/new/ https://reviews.llv

[PATCH] D73236: [clang-tidy] Add clang-tidy headers to clang distribution

2020-01-22 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. Can you upload the patch with context (`git diff -U` if you're using the web interface or via arcanist)? You'll want to add install targets for this, by adding a `COMPONENT` to the `install` command and referencing that in the target. See https://reviews.llvm.org/s

[PATCH] D73236: [clang-tidy] Add clang-tidy headers to clang distribution

2020-01-22 Thread Dmitry Polukhin via Phabricator via cfe-commits
DmitryPolukhin created this revision. DmitryPolukhin added a reviewer: smeenai. DmitryPolukhin added a project: clang-tools-extra. Herald added subscribers: xazax.hun, mgorny. Herald added a reviewer: jdoerfert. Herald added a project: clang. Clang releases include static libraries for clang-tidy