[PATCH] D73418: [WPD] Emit vcall_visibility metadata for MicrosoftCXXABI

tejohnson added a comment. In D73418#2461943 , @ayermolo wrote: > @tejohnson I was wondering where does this @anon.{{.*}} gets set, or in > general where can I find more information about it. > > When I step through the code in emitVTableTypeMetadata,

[PATCH] D73418: [WPD] Emit vcall_visibility metadata for MicrosoftCXXABI

ayermolo added a comment. @tejohnson I was wondering where does this @anon.{{.*}} gets set, or in general where can I find more information about it. When I step through the code in emitVTableTypeMetadata, it's still. @0 = private unnamed_addr constant { [2 x i8*] } { [2 x i8*] [i8* bitcast

[PATCH] D73418: [WPD] Emit vcall_visibility metadata for MicrosoftCXXABI

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf954e441a51: [WPD] Emit vcall_visibility metadata for MicrosoftCXXABI (authored by tejohnson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73418/new/

[PATCH] D73418: [WPD] Emit vcall_visibility metadata for MicrosoftCXXABI

evgeny777 accepted this revision. evgeny777 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73418/new/ https://reviews.llvm.org/D73418

[PATCH] D73418: [WPD] Emit vcall_visibility metadata for MicrosoftCXXABI

tejohnson updated this revision to Diff 240395. tejohnson added a comment. Improve test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73418/new/ https://reviews.llvm.org/D73418 Files: clang/lib/CodeGen/MicrosoftCXXABI.cpp

[PATCH] D73418: [WPD] Emit vcall_visibility metadata for MicrosoftCXXABI

tejohnson added a comment. I fixed the test matching as I found that the names generated for the anonymous namespace comdats depend on the module identifier in some way. I changed the matching to look at the struct type embedded in the initializer, which is also more intuitive. I also moved

[PATCH] D73418: [WPD] Emit vcall_visibility metadata for MicrosoftCXXABI

tejohnson created this revision. tejohnson added a reviewer: evgeny777. Herald added a subscriber: Prazek. Herald added a project: clang. The MicrosoftCXXABI uses a separate mechanism for emitting vtable type metadata, and thus didn't pick up the change from D71907