[PATCH] D73453: Preserve -nostdinc and --sysroot when calling query driver

kadircet closed this revision. kadircet added a comment. closed by 6e8d6bc9ec8739ec22b73a23f740f171f452e234 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73453/new/ https://reviews.llvm.org/D73453

[PATCH] D73453: Preserve -nostdinc and --sysroot when calling query driver

topisani added a comment. In D73453#1857095 , @kadircet wrote: > let me know if you need me to commit this. Yes please, thanks for your time! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73453/new/ https://reviews.llvm.org/D73453 _

[PATCH] D73453: Preserve -nostdinc and --sysroot when calling query driver

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks let me know if you need me to commit this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73453/new/ https://reviews.llvm.org/D73453 __

[PATCH] D73453: Preserve -nostdinc and --sysroot when calling query driver

topisani updated this revision to Diff 242334. topisani added a comment. Woops yeah, still getting used to using git like this CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73453/new/ https://reviews.llvm.org/D73453 Files: clang-tools-extra/clangd/QueryDriverDatabase.cpp clang-tool

[PATCH] D73453: Preserve -nostdinc and --sysroot when calling query driver

kadircet added a comment. it seems like the last diff is same as the previous one, maybe you've uploaded the wrong diff ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73453/new/ https://reviews.llvm.org/D73453 ___ cfe-commits mailing list

[PATCH] D73453: Preserve -nostdinc and --sysroot when calling query driver

topisani updated this revision to Diff 241914. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73453/new/ https://reviews.llvm.org/D73453 Files: clang-tools-extra/clangd/QueryDriverDatabase.cpp clang-tools-extra/clangd/test/system-include-extractor.test Index: clang-tools-extra/clangd

[PATCH] D73453: Preserve -nostdinc and --sysroot when calling query driver

kadircet added inline comments. Comment at: clang-tools-extra/clangd/QueryDriverDatabase.cpp:144 + }); + if (Found != std::end(ArgsToPreserve)) { +Arg.consume_front(*Found); nit: early exit with ``` if(Found == std::end(ArgsToPreserve)) co

[PATCH] D73453: Preserve -nostdinc and --sysroot when calling query driver

topisani updated this revision to Diff 240815. topisani marked an inline comment as done. topisani added a comment. Address CR Comments I couldn't think of a good way to check for `--sysroot /my/sysroot` in the test in posix shell, so i hope the grep usage is OK. CHANGES SINCE LAST ACTION ht

[PATCH] D73453: Preserve -nostdinc and --sysroot when calling query driver

kadircet added a comment. tests look good, but please upload the logs to the bug report for investigation. Comment at: clang-tools-extra/clangd/QueryDriverDatabase.cpp:137 +llvm::StringRef Arg = CommandLine[I]; +if (llvm::any_of(FlagsToPreserve, [&Arg](auto &&S) { retur

[PATCH] D73453: Preserve -nostdinc and --sysroot when calling query driver

topisani updated this revision to Diff 240643. topisani marked an inline comment as done. topisani added a comment. Addressed CR comments I'm sure about the tests, I basically just added to the one test that already exists that it passes one of each "type" of preservable argument. CHANGES SINC

[PATCH] D73453: Preserve -nostdinc and --sysroot when calling query driver

kadircet added a comment. Hi @topisani, thanks for working on clangd! Yes that bug fell through the cracks since the logs proposed in the comments were not making use of `-query-driver` option. Do you mind adding some logs to the bug report, without your patch so that we can clearly see its eff

[PATCH] D73453: Preserve -nostdinc and --sysroot when calling query driver

topisani created this revision. topisani added reviewers: kadircet, klimek. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, ilya-biryukov. Herald added a project: clang. Solves this issue: https://github.com/clangd/clangd/issues/157 This is my first contribution to an llvm p