[PATCH] D73617: [clangd] Don't mmap source files on all platforms --> don't crash on git checkout

This revision was automatically updated to reflect the committed changes. Closed by commit rGb500c49cd4f8: [clangd] Dont mmap source files on all platforms -- dont crash on git… (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73617: [clangd] Don't mmap source files on all platforms --> don't crash on git checkout

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73617/new/ https://reviews.llvm.org/D73617

[PATCH] D73617: [clangd] Don't mmap source files on all platforms --> don't crash on git checkout

sammccall added a comment. Also I'd like to put this onto the 10 release branch because this is a big crasher, fix seems safe, we've run this code on windows for a while. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73617/new/

[PATCH] D73617: [clangd] Don't mmap source files on all platforms --> don't crash on git checkout

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62284 tests passed, 0 failed and 831 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73617: [clangd] Don't mmap source files on all platforms --> don't crash on git checkout

sammccall created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. sammccall added reviewers: ilya-biryukov, kadircet. sammccall edited the summary of this revision. Previously we mmapped on unix