[PATCH] D73651: [OpenCL][CUDA][HIP][SYCL] Add norecurse

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGfb44b9db95a3: [OpenCL][CUDA][HIP][SYCL] Add norecurse (authored by yaxunl). Herald added subscribers: kerbowa, nhaehnle,

[PATCH] D73651: [OpenCL][CUDA][HIP][SYCL] Add norecurse

Anastasia accepted this revision. Anastasia added a comment. LGTM! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73651/new/ https://reviews.llvm.org/D73651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D73651: [OpenCL][CUDA][HIP][SYCL] Add norecurse

yaxunl updated this revision to Diff 242300. yaxunl marked 5 inline comments as done. yaxunl added a comment. revised by Anastasia's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73651/new/ https://reviews.llvm.org/D73651 Files: clang/lib/CodeGen/CodeGenFunction.cpp

[PATCH] D73651: [OpenCL][CUDA][HIP][SYCL] Add norecurse

Anastasia added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:914 + // + // OpenCL C++ 1.0 v2.1-11 s2.9: + // recursive function calls (ISO C++ Section 5.2.2, item 9) unless Can we remove reference to OpenCL C++ since it's not

[PATCH] D73651: [OpenCL][CUDA][HIP][SYCL] Add norecurse

yaxunl updated this revision to Diff 241877. yaxunl added a comment. Fix SYCL version. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73651/new/ https://reviews.llvm.org/D73651 Files: clang/lib/CodeGen/CodeGenFunction.cpp clang/test/CodeGenCUDA/norecurse.cu

[PATCH] D73651: [OpenCL][CUDA][HIP][SYCL] Add norecurse

keryell requested changes to this revision. keryell added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:918 + // + // SYCL v2.2 s2.10: + // kernels cannot include RTTI information, exception classes,

[PATCH] D73651: [OpenCL][CUDA][HIP][SYCL] Add norecurse

bader accepted this revision. bader added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73651/new/ https://reviews.llvm.org/D73651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D73651: [OpenCL][CUDA][HIP][SYCL] Add norecurse

yaxunl updated this revision to Diff 241335. yaxunl added a comment. Remove the ToDo for CUDA/HIP. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73651/new/ https://reviews.llvm.org/D73651 Files: clang/lib/CodeGen/CodeGenFunction.cpp clang/test/CodeGenCUDA/norecurse.cu

[PATCH] D73651: [OpenCL][CUDA][HIP][SYCL] Add norecurse

t-tye added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:918 + // + // ToDo: clang does not support CUDA/HIP dynamic parallelism, therefore + // CUDA/HIP kernel can be marked with norecurse. This may change in the tra wrote: > I believe

[PATCH] D73651: [OpenCL][CUDA][HIP][SYCL] Add norecurse

yaxunl updated this revision to Diff 241265. yaxunl edited the summary of this revision. yaxunl added a comment. revised by Alexey's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73651/new/ https://reviews.llvm.org/D73651 Files: clang/lib/CodeGen/CodeGenFunction.cpp

[PATCH] D73651: [OpenCL][CUDA][HIP][SYCL] Add norecurse

bader added a comment. In D73651#1847862 , @yaxunl wrote: > Added handling of SYCL kernels by Alexey's comments. I cannot add a codegen > test for SYCL since I cannot find a way to instantiate a SYCL kernel. I think SYCL implementation should follow

[PATCH] D73651: [OpenCL][CUDA][HIP][SYCL] Add norecurse

yaxunl updated this revision to Diff 241256. yaxunl retitled this revision from "[OpenCL][CUDA][HIP] Add norecurse" to "[OpenCL][CUDA][HIP][SYCL] Add norecurse". yaxunl edited the summary of this revision. yaxunl added a comment. Herald added a subscriber: ebevhan. Added handling of SYCL kernels