Charusso added a comment.
[Achievement unlocked] 3 green marks.
Thanks!
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73729/new/
https://reviews.llvm.org/D73729
___
cfe-commits mailing list
This revision was automatically updated to reflect the committed changes.
Closed by commit rGabdd33c86a34: [analyzer] AnalyzerOptions: Remove
fixits-as-remarks (authored by Charusso).
Changed prior to commit:
https://reviews.llvm.org/D73729?vs=241507=248106#toc
Repository:
rG LLVM Github
Szelethus accepted this revision.
Szelethus added a comment.
Looks great! Thanks!
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73729/new/
https://reviews.llvm.org/D73729
___
cfe-commits mailing list
xazax.hun added inline comments.
Comment at: clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.def:310
-ANALYZER_OPTION(bool, ShouldEmitFixItHintsAsRemarks, "fixits-as-remarks",
-"Emit fix-it hints as remarks for testing purposes",
-false)
NoQ added inline comments.
Comment at: clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.def:310
-ANALYZER_OPTION(bool, ShouldEmitFixItHintsAsRemarks, "fixits-as-remarks",
-"Emit fix-it hints as remarks for testing purposes",
-false)
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Great, thanks!!
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73729/new/
https://reviews.llvm.org/D73729
___
xazax.hun added a reviewer: Szelethus.
xazax.hun added a comment.
Herald added subscribers: martong, steakhal.
Maybe Kristof has some opinion whether we still need this :) He might be up to
date whether CodeChecker is using this feature.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
Charusso created this revision.
Charusso added a reviewer: NoQ.
Charusso added a project: clang.
Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus,
mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun.
Charusso added a parent revision: D69746: [analyzer] FixItHint:
