[PATCH] D73755: [objc_direct] Small updates to help with adoption.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3adcc78a8071: [objc_direct] Small updates to help with adoption. (authored by MadCoder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73755/new/ https://re

[PATCH] D73755: [objc_direct] Small updates to help with adoption.

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM, thanks. Comment at: clang/lib/Sema/SemaObjCProperty.cpp:2436 + if (!GetterMethod) { +if (const ObjCCategoryDecl *CatDecl = dyn_cast(CD)) { +

[PATCH] D73755: [objc_direct] Small updates to help with adoption.

MadCoder added inline comments. Comment at: clang/lib/Sema/SemaObjCProperty.cpp:1630-1637 + if (PIDecl->getPropertyImplementation() == ObjCPropertyImplDecl::Dynamic && + PIDecl->getPropertyDecl() && + PIDecl->getPropertyDecl()->isDirectProperty()) { +Diag(PropertyL

[PATCH] D73755: [objc_direct] Small updates to help with adoption.

MadCoder updated this revision to Diff 244773. MadCoder marked 10 inline comments as done. MadCoder added a comment. @erik.pilkington review feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73755/new/ https://reviews.llvm.org/D73755 Files: clang/include/clang/Basic/Attr.td cl

[PATCH] D73755: [objc_direct] Small updates to help with adoption.

MadCoder added a comment. In D73755#1874962 , @plotfi wrote: > @MadCoder Could there be a way to mark objc_direct methods as something like > __attribute__((visibility("default"))) or __declspec(dllexport) to denote > that a given method should be direct

[PATCH] D73755: [objc_direct] Small updates to help with adoption.

plotfi added a comment. @MadCoder Could there be a way to mark objc_direct methods as something like __attribute__((visibility("default"))) or __declspec(dllexport) to denote that a given method should be directly callable but still retain the metadata to be called through an objc_msgSend from

[PATCH] D73755: [objc_direct] Small updates to help with adoption.

erik.pilkington added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:1005-1006 def err_objc_direct_duplicate_decl : Error< - "%select{|direct }0method declaration conflicts " - "with previous %select{|direct }1declaration of method %2">; + "%sel

[PATCH] D73755: [objc_direct] Small updates to help with adoption.

MadCoder updated this revision to Diff 243649. MadCoder added a comment. Add some errors when direct properties are marked @dynamic. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73755/new/ https://reviews.llvm.org/D73755 Files: clang/include/clang/Basic/Attr.td clang/include/cla

[PATCH] D73755: [objc_direct] Small updates to help with adoption.

MadCoder created this revision. MadCoder added reviewers: ahatanak, dexonsmith, arphaman, erik.pilkington. MadCoder added a project: clang. Herald added subscribers: cfe-commits, jfb. Add fixits for messaging self in MRR or using super, as the intent is clear, and it turns out people do that a lot