[PATCH] D74051: Move update_cc_test_checks.py tests to clang

mgorny added a comment. In D74051#2211869 , @tstellar wrote: > In D74051#2017115 , @mgorny wrote: > >> Nevermind, I figured out good enough workaround. > > What was the workaround? Unpack `llvm/utils/{UpdateTestChe

[PATCH] D74051: Move update_cc_test_checks.py tests to clang

tstellar added a comment. In D74051#2017115 , @mgorny wrote: > Nevermind, I figured out good enough workaround. What was the workaround? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74051/new/ https://rev

[PATCH] D74051: Move update_cc_test_checks.py tests to clang

mgorny resigned from this revision. mgorny added a comment. This revision is now accepted and ready to land. Nevermind, I figured out good enough workaround. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74051/new/ https://reviews.llvm.org/D74051

[PATCH] D74051: Move update_cc_test_checks.py tests to clang

arichardson added a comment. In D74051#2016101 , @mgorny wrote: > In D74051#2016085 , @lebedev.ri > wrote: > > > In D74051#2016078 , @mgorny wrote: > > > > > This broke runn

[PATCH] D74051: Move update_cc_test_checks.py tests to clang

mgorny added a comment. In D74051#2016085 , @lebedev.ri wrote: > In D74051#2016078 , @mgorny wrote: > > > This broke running clang tests stand-alone: > > > > Traceback (most recent call last): > > File > > "/

[PATCH] D74051: Move update_cc_test_checks.py tests to clang

lebedev.ri added a comment. In D74051#2016078 , @mgorny wrote: > This broke running clang tests stand-alone: > > Traceback (most recent call last): > File > "/var/tmp/portage/sys-devel/clang-11.0.0./work/x/y/clang-abi_x86_64.amd64/bin/../../llvm

[PATCH] D74051: Move update_cc_test_checks.py tests to clang

mgorny reopened this revision. mgorny added a comment. This revision is now accepted and ready to land. This broke running clang tests stand-alone: Traceback (most recent call last): File "/var/tmp/portage/sys-devel/clang-11.0.0./work/x/y/clang-abi_x86_64.amd64/bin/../../llvm/utils/lit

[PATCH] D74051: Move update_cc_test_checks.py tests to clang

thakis added a comment. Yep, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74051/new/ https://reviews.llvm.org/D74051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D74051: Move update_cc_test_checks.py tests to clang

arichardson added a comment. Turns out those scripts use different code to write the updated file. The failure should hopefully be fixed in rGc29310707e9a85e70a226277657cd9d9182a5d04 Repository: rG LLVM Github Monorepo CH

[PATCH] D74051: Move update_cc_test_checks.py tests to clang

arichardson added a comment. In D74051#1876291 , @thakis wrote: > Fails on windows, looks like line endings: > http://45.33.8.238/win/8350/step_7.txt Are the other update_test_checks.py and update_llc_test_checks.py tests running on that bot? I would e

[PATCH] D74051: Move update_cc_test_checks.py tests to clang

thakis added a comment. Fails on windows, looks like line endings: http://45.33.8.238/win/8350/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74051/new/ https://reviews.llvm.org/D74051 ___ c

[PATCH] D74051: Move update_cc_test_checks.py tests to clang

This revision was automatically updated to reflect the committed changes. Closed by commit rG61dd0603bd8a: Move update_cc_test_checks.py tests to clang (authored by arichardson). Changed prior to commit: https://reviews.llvm.org/D74051?vs=243859&id=244650#toc Repository: rG LLVM Github Monor

[PATCH] D74051: Move update_cc_test_checks.py tests to clang

rsmith added a comment. In D74051#1872856 , @MaskRay wrote: > @rsmith Does `clang/test/utils/` (a new directory) look appropriate to you? That seems fine to me. Following that pattern, I think we should also move: - `test/clang-rename` -> `test/tools/cl

[PATCH] D74051: Move update_cc_test_checks.py tests to clang

MaskRay accepted this revision. MaskRay added a comment. @rsmith Does `clang/test/utils/` (a new directory) look appropriate to you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74051/new/ https://reviews.llvm.org/D74051 ___

[PATCH] D74051: Move update_cc_test_checks.py tests to clang

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. LGTM, i guess Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74051/new/ https://reviews.llvm.org/D74051 ___