[PATCH] D74054: [clangd] Include the underlying decls in go-to-definition.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:997 +)cpp", +R"cpp( + class Foo {}; this is basically the same as th

[PATCH] D74054: [clangd] Include the underlying decls in go-to-definition.

hokein updated this revision to Diff 283851. hokein marked 2 inline comments as done. hokein added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74054/new/ https://reviews.llvm.org/D74054 Files: clang-tools-extra/clan

[PATCH] D74054: [clangd] Include the underlying decls in go-to-definition.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa70161808bcd: [clangd] Include the underlying decls in go-to-definition. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D74054: [clangd] Include the underlying decls in go-to-definition.

hokein updated this revision to Diff 270715. hokein marked 2 inline comments as done. hokein added a comment. address review comment: fix the wrong result for multiple overloads. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74054/new/ https://revi

[PATCH] D74054: [clangd] Include the underlying decls in go-to-definition.

sammccall added a comment. Sorry about being late coming back to this. Comment at: clang-tools-extra/clangd/XRefs.cpp:307 +// alias. +if (llvm::isa(D)) { + llvm::for_each(targetDecl(ast_type_traits::DynTypedNode::create(*D), I believe this is going

[PATCH] D74054: [clangd] Include the underlying decls in go-to-definition.

hokein added a comment. friendly ping, this patch should be ready for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74054/new/ https://reviews.llvm.org/D74054 ___ cfe-commits mailing list cfe-c

[PATCH] D74054: [clangd] Include the underlying decls in go-to-definition.

nridge added inline comments. Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:695 + namespace ns { class [[Foo]] {}; } + using ns::[[F^oo]]; +)cpp", Why is it useful to give the using-declaration itself as a result? It seems like the

[PATCH] D74054: [clangd] Include the underlying decls in go-to-definition.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Fixes https://github.com/clangd/clangd/issues/277 Repository: rG LLVM Github Monorepo https://reviews.llv

[PATCH] D74054: [clangd] Include the underlying decls in go-to-definition.

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : CMak

[PATCH] D74054: [clangd] Include the underlying decls in go-to-definition.

hokein planned changes to this revision. hokein marked an inline comment as done. hokein added inline comments. Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:674 -c^allback foo; - )cpp"); - auto AST = TestTU::withCode(T.code()).build(); - EXPECT_THAT(loca

[PATCH] D74054: [clangd] Include the underlying decls in go-to-definition.

hokein updated this revision to Diff 242855. hokein added a comment. no regression on non-definition of renaming alias. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74054/new/ https://reviews.llvm.org/D74054 Files: clang-tools-extra/clangd/XRef

[PATCH] D74054: [clangd] Include the underlying decls in go-to-definition.

hokein updated this revision to Diff 242856. hokein added a comment. remove an accident change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74054/new/ https://reviews.llvm.org/D74054 Files: clang-tools-extra/clangd/XRefs.cpp clang-tools-extr