[PATCH] D74131: [analyzer][taint] Add isTainted debug expression inspection check

This revision was automatically updated to reflect the committed changes. steakhal marked an inline comment as done. Closed by commit rG859bcf4e3bb9: [analyzer][taint] Add isTainted debug expression inspection check (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D74131: [analyzer][taint] Add isTainted debug expression inspection check

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. LGTM, thanks! Feel free to commit as you're ready. Comment at: clang/lib/StaticAnalyzer/Checkers/ExprInspectionChecker.cpp:97 .Case("clang_analyzer_express",

[PATCH] D74131: [analyzer][taint] Add isTainted debug expression inspection check

steakhal marked 2 inline comments as done. steakhal added a comment. Marking comments done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74131/new/ https://reviews.llvm.org/D74131 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D74131: [analyzer][taint] Add isTainted debug expression inspection check

steakhal updated this revision to Diff 246420. steakhal added a comment. Declaring the purpose of this checker: > [...] > This would help to reduce the *noise* that the `TaintTest` debug checker > would > introduce and let you focus on the `expected-warning`s that you really care >

[PATCH] D74131: [analyzer][taint] Add isTainted debug expression inspection check

Szelethus added a reviewer: boga95. Szelethus added a comment. In D74131#1884372 , @steakhal wrote: > If this patch is good to go, could someone commit it? > I don't have commit access (yet). I think you can apply for a commit access, you have a

[PATCH] D74131: [analyzer][taint] Add isTainted debug expression inspection check

steakhal added a comment. Herald added a subscriber: martong. If this patch is good to go, could someone commit it? I don't have commit access (yet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74131/new/ https://reviews.llvm.org/D74131

[PATCH] D74131: [analyzer][taint] Add isTainted debug expression inspection check

steakhal updated this revision to Diff 243146. steakhal added a comment. Clarified example usage, especially in contrast of eg.: `debug.TaintTest` checker. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74131/new/ https://reviews.llvm.org/D74131

[PATCH] D74131: [analyzer][taint] Add isTainted debug expression inspection check

steakhal updated this revision to Diff 243144. steakhal added a comment. - Tests added. - Clang-format-diff applied. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74131/new/ https://reviews.llvm.org/D74131 Files:

[PATCH] D74131: [analyzer][taint] Add isTainted debug expression inspection check

Szelethus added a comment. After tests are added and `clang-format-diff.py` is ran, this would be an amazing patch, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74131/new/ https://reviews.llvm.org/D74131

[PATCH] D74131: [analyzer][taint] Add isTainted debug expression inspection check

xazax.hun added a comment. Please add a test as well. Otherwise looks good. Comment at: clang/lib/StaticAnalyzer/Checkers/ExprInspectionChecker.cpp:97 .Case("clang_analyzer_express", ::analyzerExpress) +.StartsWith("clang_analyzer_isTainted", ::analyzerIsTainted)

[PATCH] D74131: [analyzer][taint] Add isTainted debug expression inspection check

steakhal created this revision. steakhal added reviewers: NoQ, Szelethus. steakhal added a project: clang. Herald added subscribers: cfe-commits, Charusso, donat.nagy, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun, whisperity. This patch introduces the