[PATCH] D74395: [clangd] Add tracer to the rename workflow, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG74c97ca1b4b7: [clangd] Add tracer to the rename workflow, NFC (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74395/new/ https://reviews

[PATCH] D74395: [clangd] Add tracer to the rename workflow, NFC

kbobyrev accepted this revision. kbobyrev added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:345 + +SPAN_ATTACH(Tracer, FileAndOccurrences.first(), +static_cast(Ranges.size()));

[PATCH] D74395: [clangd] Add tracer to the rename workflow, NFC

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:345 + +SPAN_ATTACH(Tracer, FileAndOccurrences.first(), +static_cast(Ranges.size())); kbobyrev wrote: > A tracer message here would be helpful! the message n

[PATCH] D74395: [clangd] Add tracer to the rename workflow, NFC

hokein updated this revision to Diff 244384. hokein marked 3 inline comments as done. hokein added a comment. address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74395/new/ https://reviews.llvm.org/D74395 Files: clang-tools-ex

[PATCH] D74395: [clangd] Add tracer to the rename workflow, NFC

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:345 + +SPAN_ATTACH(Tracer, FileAndOccurrences.first(), +static_cast(Ranges.size())); A tracer message here would be helpful! Comment at

[PATCH] D74395: [clangd] Add tracer to the rename workflow, NFC

hokein created this revision. hokein added a reviewer: kbobyrev. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D74395 Files: clang-tools-extra/clangd/refac