[PATCH] D74455: [MS] Pass aligned, non-trivially copyable things indirectly on x86

2020-09-24 Thread Reid Kleckner via Phabricator via cfe-commits
rnk abandoned this revision. rnk added a comment. I actually forgot about this change entirely and uploaded and landed a new one: https://reviews.llvm.org/D87923 I suppose they are functionally different: if we have an overaligned type that can be passed in registers due to [[trivial_abi]], we s

[PATCH] D74455: [MS] Pass aligned, non-trivially copyable things indirectly on x86

2020-02-25 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74455/new/ https://reviews.llvm.org/D74455 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D74455: [MS] Pass aligned, non-trivially copyable things indirectly on x86

2020-02-19 Thread Reid Kleckner via Phabricator via cfe-commits
rnk updated this revision to Diff 245491. rnk added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74455/new/ https://reviews.llvm.org/D74455 Files: clang/lib/CodeGen/MicrosoftCXXABI.cpp clang/test/CodeGenCXX/inalloca-overal

[PATCH] D74455: [MS] Pass aligned, non-trivially copyable things indirectly on x86

2020-02-11 Thread Reid Kleckner via Phabricator via cfe-commits
rnk created this revision. rnk added reviewers: craig.topper, erichkeane. Herald added a project: clang. This is a follow-up to case 1 in D72114 . The C++ argument classification logic supersedes the C rules, so we have to add a second check for overaligned record