[PATCH] D74542: [ASTImporter] Prevent the ASTImporter from creating multiple main FileIDs.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa37734f643fb: [ASTImporter] Prevent the ASTImporter from creating multiple main FileIDs. (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74542: [ASTImporter] Prevent the ASTImporter from creating multiple main FileIDs.

teemperor added a comment. In D74542#1878732 , @balazske wrote: > In D74542#1878576 , @teemperor wrote: > > > @balazske Do you see any problems with this patch? > > > I have no opinion against the change. Probably

[PATCH] D74542: [ASTImporter] Prevent the ASTImporter from creating multiple main FileIDs.

balazske added a comment. In D74542#1878576 , @teemperor wrote: > @balazske Do you see any problems with this patch? I have no opinion against the change. Probably sorting order of imported source locations makes not much sense (specially if recursive

[PATCH] D74542: [ASTImporter] Prevent the ASTImporter from creating multiple main FileIDs.

teemperor added a comment. @balazske Do you see any problems with this patch? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74542/new/ https://reviews.llvm.org/D74542 ___ cfe-commits mailing list

[PATCH] D74542: [ASTImporter] Prevent the ASTImporter from creating multiple main FileIDs.

a_sidorin accepted this revision. a_sidorin added a comment. Nice solution! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74542/new/ https://reviews.llvm.org/D74542 ___ cfe-commits mailing list

[PATCH] D74542: [ASTImporter] Prevent the ASTImporter from creating multiple main FileIDs.

martong added a comment. In D74542#1874221 , @teemperor wrote: > In D74542#1874201 , @martong wrote: > > > Looks good to me! Thanks! > > Adding @balazske as another reviewer though. He worked on something > >

[PATCH] D74542: [ASTImporter] Prevent the ASTImporter from creating multiple main FileIDs.

teemperor added a comment. In D74542#1874201 , @martong wrote: > Looks good to me! Thanks! > Adding @balazske as another reviewer though. He worked on something related > to this, where we also experienced an assert in `isBeforeInTranslationUnit`.

[PATCH] D74542: [ASTImporter] Prevent the ASTImporter from creating multiple main FileIDs.

martong accepted this revision. martong added a reviewer: balazske. martong added a subscriber: balazske. martong added a comment. This revision is now accepted and ready to land. Looks good to me! Thanks! Adding @balazske as another reviewer though. He worked on something related to this, where

[PATCH] D74542: [ASTImporter] Prevent the ASTImporter from creating multiple main FileIDs.

teemperor created this revision. teemperor added reviewers: martong, a_sidorin. Herald added subscribers: cfe-commits, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. When importing the main FileID the ASTImporter currently gives it no