This revision was automatically updated to reflect the committed changes.
Closed by commit rG633db60f3ed0: [AArch64][SVE] Add SVE index intrinsic
(authored by kmclaughlin).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74550/new/
sdesmalen added a comment.
Nice, thanks for adding those tests @kmclaughlin. LGTM!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74550/new/
https://reviews.llvm.org/D74550
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
kmclaughlin updated this revision to Diff 244610.
kmclaughlin added a comment.
- Changed 'dl' to 'DL' as suggested by @andwar
- Updated tests to address @sdesmalen's comment (changed all tests to check min
& max immediate values, plus added some tests where the immediate is out of
range)
sdesmalen added inline comments.
Comment at: llvm/test/CodeGen/AArch64/sve-intrinsics-index.ll:35
+; CHECK-NEXT: ret
+ %out = call @llvm.aarch64.sve.index.nxv2i64(i64 -14, i64
15)
+ ret %out
Is there a reason you're not testing for -16, 15 for all of these
andwar added inline comments.
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:10923
+static SDValue LowerSVEIntrinsicIndex(SDNode *N, SelectionDAG ) {
+ SDLoc dl(N);
+ SDValue Op1 = N->getOperand(1);
[nit] This should be `DL`:
cameron.mcinally accepted this revision.
cameron.mcinally added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: tatyana-krasnukha.
LGTM
Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:804
+[IntrNoMem]>;
+
class
kmclaughlin created this revision.
kmclaughlin added reviewers: sdesmalen, andwar, efriedma, dancgr,
cameron.mcinally.
Herald added subscribers: psnobl, arphaman, rkruppe, hiraditya, kristof.beyls,
tschuett.
Herald added a reviewer: rengolin.
Herald added a project: LLVM.
Implements the
