This revision was automatically updated to reflect the committed changes.
Closed by commit rGba3f863dfb9c: [OpenMP][OMPIRBuilder] Introducing the
`OMPBuilderCBHelpers` helper class (authored by fghanim, committed by
jdoerfert).
Changed prior to commit:
https://reviews.llvm.org/D74562?vs=245227
fghanim added a comment.
I am done updating this patch.
I still don't have commit access, I'd appreciate it if you'd commit this for me
when you get a chance.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74562/new/
https://reviews.llvm.org/D74562
fghanim updated this revision to Diff 245227.
fghanim added a comment.
Marking a call void
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74562/new/
https://reviews.llvm.org/D74562
Files:
clang/lib/CodeGen/CGStmtOpenMP.cpp
clang/lib/CodeGen/Cod
fghanim updated this revision to Diff 245151.
fghanim added a comment.
addressing review comments - Adding a comment to explain minor change.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74562/new/
https://reviews.llvm.org/D74562
Files:
clang/l
jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.
LGTM assuming the comment below is addressed.
Comment at: clang/lib/CodeGen/CodeGenFunction.h:354
+
+FinilizationBlock = CGF.getJumpDestInCurrentScope(&FiniBB);
fghanim added a comment.
Regarding the third comment (which was removed for some reason), This new
update should fix that
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:3134
// TODO: Replace with a generic helper function for emitting body
auto BodyGenCB = [MasterR
fghanim updated this revision to Diff 245014.
fghanim marked 2 inline comments as done.
fghanim added a comment.
Fixed bug where variables where still being allocated in original function
entry block
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74
jdoerfert added a comment.
This is great, thanks a lot! I only have two comments where I am not sure I
understand the code/change.
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:3134
// TODO: Replace with a generic helper function for emitting body
auto BodyGenCB =
fghanim created this revision.
fghanim added a reviewer: jdoerfert.
Herald added subscribers: cfe-commits, guansong.
Herald added a project: clang.
This patch introduces a new helper class `OMPBuilderCBHelpers`,
which will contain all reusable C/C++ language specific function-
alities required by
