[PATCH] D74643: [Parse] Consider attributes in `TryParsePtrOperatorSeq`.

2020-02-23 Thread Michele Scandale via Phabricator via cfe-commits
michele.scandale updated this revision to Diff 246139. michele.scandale added a comment. Herald added a subscriber: jfb. Tests for `__attribute__(())` syntax + attribute arguments + fix for `_Atomic` qualifier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74643: [Parse] Consider attributes in `TryParsePtrOperatorSeq`.

2020-02-23 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseTentative.cpp:773 + while (Tok.isOneOf(tok::l_square, tok::kw___attribute, tok::kw___declspec, + tok::kw_alignas)) { +if (Tok.is(tok::l_square)) { rsmith wrote: >

[PATCH] D74643: [Parse] Consider attributes in `TryParsePtrOperatorSeq`.

2020-02-23 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added inline comments. Comment at: clang/lib/Parse/ParseTentative.cpp:773 + while (Tok.isOneOf(tok::l_square, tok::kw___attribute, tok::kw___declspec, + tok::kw_alignas)) { +if (Tok.is(tok::l_square)) { aaron.ballman wrote: > Do

[PATCH] D74643: [Parse] Consider attributes in `TryParsePtrOperatorSeq`.

2020-02-23 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman requested changes to this revision. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseTentative.cpp:773 + while (Tok.isOneOf(tok::l_square, tok::kw___attribute, tok::kw___declspec, +

[PATCH] D74643: [Parse] Consider attributes in `TryParsePtrOperatorSeq`.

2020-02-22 Thread Michele Scandale via Phabricator via cfe-commits
michele.scandale updated this revision to Diff 246095. michele.scandale added a comment. Fixed comment wording + rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74643/new/ https://reviews.llvm.org/D74643 Files:

[PATCH] D74643: [Parse] Consider attributes in `TryParsePtrOperatorSeq`.

2020-02-22 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added inline comments. Comment at: clang/include/clang/Parse/Parser.h:2444 + /// Try to skip a possibly empty sequence of 'attribute-specifier' without of + /// full validation of the syntactic structure of attributes.

[PATCH] D74643: [Parse] Consider attributes in `TryParsePtrOperatorSeq`.

2020-02-21 Thread Michele Scandale via Phabricator via cfe-commits
michele.scandale added a comment. @rsmith: is this fine for you as well? If this is ready for landing, I would appreciate if somebody can land this on my behalf since I do not have commit rights. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74643: [Parse] Consider attributes in `TryParsePtrOperatorSeq`.

2020-02-17 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74643/new/ https://reviews.llvm.org/D74643 ___ cfe-commits mailing list

[PATCH] D74643: [Parse] Consider attributes in `TryParsePtrOperatorSeq`.

2020-02-17 Thread Michele Scandale via Phabricator via cfe-commits
michele.scandale marked an inline comment as done. michele.scandale added a comment. Assuming this is fine, I would need someone landing this change on my behalf since I do not have commit rights. Thanks! Comment at: clang/lib/Parse/ParseTentative.cpp:780 + if

[PATCH] D74643: [Parse] Consider attributes in `TryParsePtrOperatorSeq`.

2020-02-17 Thread Michele Scandale via Phabricator via cfe-commits
michele.scandale updated this revision to Diff 245073. michele.scandale added a comment. Add comment about ObjC message send being rejected + rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74643/new/ https://reviews.llvm.org/D74643 Files:

[PATCH] D74643: [Parse] Consider attributes in `TryParsePtrOperatorSeq`.

2020-02-17 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Parse/ParseTentative.cpp:780 + if (!SkipUntil(tok::r_square) || Tok.isNot(tok::r_square)) +return false; + ConsumeBracket();

[PATCH] D74643: [Parse] Consider attributes in `TryParsePtrOperatorSeq`.

2020-02-17 Thread Michele Scandale via Phabricator via cfe-commits
michele.scandale marked an inline comment as done. michele.scandale added inline comments. Comment at: clang/lib/Parse/ParseTentative.cpp:798 +if (Tok.is(tok::l_square)) { + ConsumeBracket(); + if (!SkipUntil(tok::r_square)) rjmccall

[PATCH] D74643: [Parse] Consider attributes in `TryParsePtrOperatorSeq`.

2020-02-17 Thread Michele Scandale via Phabricator via cfe-commits
michele.scandale updated this revision to Diff 245068. michele.scandale added a comment. Check for double brackets for C++11 style attributes, and outline the loop to skip attributes in `TrySkipAttributes` to fix also the other use in `TryConsumeDeclarationSpecifier` Repository: rG LLVM

[PATCH] D74643: [Parse] Consider attributes in `TryParsePtrOperatorSeq`.

2020-02-17 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: clang/lib/Parse/ParseTentative.cpp:798 +if (Tok.is(tok::l_square)) { + ConsumeBracket(); + if (!SkipUntil(tok::r_square)) Do you want to check for double-brackets here? Repository: rG LLVM

[PATCH] D74643: [Parse] Consider attributes in `TryParsePtrOperatorSeq`.

2020-02-14 Thread Michele Scandale via Phabricator via cfe-commits
michele.scandale created this revision. michele.scandale added reviewers: rjmccall, rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. michele.scandale updated this revision to Diff 244756. michele.scandale added a comment. Missed GNU style attributes The syntax

[PATCH] D74643: [Parse] Consider attributes in `TryParsePtrOperatorSeq`.

2020-02-14 Thread Michele Scandale via Phabricator via cfe-commits
michele.scandale updated this revision to Diff 244756. michele.scandale added a comment. Missed GNU style attributes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74643/new/ https://reviews.llvm.org/D74643 Files: