[PATCH] D74844: [clangd] Get rid of Lexer usage in CodeComplete

2020-02-20 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:593 + llvm::StringRef SpelledSpecifier = + syntax::FileRange(CCSema.SourceMgr, SemaSpecifier->getBeginLoc(), +SemaSpecifi

[PATCH] D74844: [clangd] Get rid of Lexer usage in CodeComplete

2020-02-19 Thread Sam McCall via Phabricator via cfe-commits
sammccall added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:593 + llvm::StringRef SpelledSpecifier = + syntax::FileRange(CCSema.SourceMgr, SemaSpecifier->getBeginLoc(), +SemaSpecifier->getEndLoc()) what if

[PATCH] D74844: [clangd] Get rid of Lexer usage in CodeComplete

2020-02-19 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D74844 Files: clang-tools-extra/clan