[PATCH] D74871: Fix interaction between -fdiscard-value-names and LLVM Bitcode

serge-sans-paille abandoned this revision. serge-sans-paille added a comment. Obsoleted by https://reviews.llvm.org/D74878 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74871/new/ https://reviews.llvm.org/D74871

[PATCH] D74871: Fix interaction between -fdiscard-value-names and LLVM Bitcode

hans added a reviewer: xur. hans added a comment. Thanks for looking into this, Serge! I used your test case to bisect where the crashing started, and ended up at 60d39479221d6bc09060f7816bcd7c54eb286603 Someone else noted

[PATCH] D74871: Fix interaction between -fdiscard-value-names and LLVM Bitcode

serge-sans-paille updated this revision to Diff 245606. serge-sans-paille added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Other approach to the problem: modify `Value::SetNameImpl` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74871: Fix interaction between -fdiscard-value-names and LLVM Bitcode

serge-sans-paille updated this revision to Diff 245594. serge-sans-paille added a comment. Finally, the test case :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74871/new/ https://reviews.llvm.org/D74871 Files:

[PATCH] D74871: Fix interaction between -fdiscard-value-names and LLVM Bitcode

serge-sans-paille added a comment. In D74871#1883884 , @EricWF wrote: > Why is this not a bug in w/e is handling the IR? It may totally be. Consider this review as a way to start the discussion. The problem, as it appears, is triggered when some value

[PATCH] D74871: Fix interaction between -fdiscard-value-names and LLVM Bitcode

serge-sans-paille updated this revision to Diff 245578. serge-sans-paille added a comment. Added test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74871/new/ https://reviews.llvm.org/D74871 Files:

[PATCH] D74871: Fix interaction between -fdiscard-value-names and LLVM Bitcode

EricWF added a comment. This seems wrong to me. Discarding value names is the default and has been forever in non-assert builds. Why is this not a bug in w/e is handling the IR? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74871/new/

[PATCH] D74871: Fix interaction between -fdiscard-value-names and LLVM Bitcode

mehdi_amini added a comment. You mention a test case in the description but I don't see it? Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3607 +// Cannot discard value names when processing llvm-ir, because IR loading +// is conservative wrt. names. +if

[PATCH] D74871: Fix interaction between -fdiscard-value-names and LLVM Bitcode

serge-sans-paille created this revision. serge-sans-paille added reviewers: EricWF, mehdi_amini. Herald added a project: clang. Herald added a subscriber: cfe-commits. Without that patch, the test case associated to this patch segfaults in Release mode. This also makes the llvm-test-suite build