This revision was automatically updated to reflect the committed changes.
Closed by commit rG8a37b9e61798: [OpenCL] Remove spurious atomic_fetch_min/max
builtins (authored by svenvh).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74910/new/
https://
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74910/new/
https://reviews.llvm.org/D74910
___
cfe-c
Anastasia added a comment.
I would say if we are not aware of any test that this change breaks, let's go
ahead and commit this?
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74910/new/
https://reviews.llvm.org/D74910
__
b-sumner added a comment.
I recall we agreed that conformance tests using mixed types were broken, so
this change should be OK. Hopefully this will not affect users.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74910/new/
https://reviews.llvm.org/D74910
___
yaxunl added a comment.
Are you sure this change will not break OpenCL conformance tests? I remember
they are there for some reason.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74910/new/
https://reviews.llvm.org/D74910
_
svenvh created this revision.
svenvh added reviewers: Anastasia, yaxunl.
Herald added subscribers: cfe-commits, kristina, jfb.
Herald added a project: clang.
These declarations use a mix of unsigned and signed argument and
return types. This is not defined in OpenCL v2.0 s6.13.11.
Repository:
