[PATCH] D75057: Syndicate, test and fix base64 implementation

hctim added a comment. Looks like this change broke the UBSan build bots: FAIL: LLVM-Unit :: Support/./SupportTests/Base64Test.Base64 (3484 of 36324) TEST 'LLVM-Unit :: Support/./SupportTests/Base64Test.Base64' FAILED Note: Google Test filter =

[PATCH] D75057: Syndicate, test and fix base64 implementation

This revision was automatically updated to reflect the committed changes. Closed by commit rG5a1958f2673f: Syndicate, test and fix base64 implementation (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75057/new/

[PATCH] D75057: Syndicate, test and fix base64 implementation

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. In D75057#1896114 , @serge-sans-paille wrote: > In D75057#1895550 , @hokein wrote: > > > thanks for doing

[PATCH] D75057: Syndicate, test and fix base64 implementation

serge-sans-paille marked 3 inline comments as done. serge-sans-paille added inline comments. Comment at: llvm/unittests/Support/Base64Test.cpp:30 + // from: https://tools.ietf.org/html/rfc4648#section-10 + TestBase64("", ""); + TestBase64("f", "Zg=="); hokein

[PATCH] D75057: Syndicate, test and fix base64 implementation

serge-sans-paille updated this revision to Diff 247039. serge-sans-paille added a comment. Add a test case that exhibits the overflow in previous implementation + minor nits from @hokein Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75057/new/

[PATCH] D75057: Syndicate, test and fix base64 implementation

serge-sans-paille added a comment. In D75057#1895550 , @hokein wrote: > thanks for doing this! didn't look into details yet. Could you explain what > was the bug in the previous code? Yeah, the code was using + operator instead of | to combine the

[PATCH] D75057: Syndicate, test and fix base64 implementation

hokein added a comment. thanks for doing this! didn't look into details yet. Could you explain what was the bug in the previous code? since this patch contains some refactoring changes, it is not quite straightforward to spot it. Comment at:

[PATCH] D75057: Syndicate, test and fix base64 implementation

serge-sans-paille added a comment. Up? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75057/new/ https://reviews.llvm.org/D75057 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D75057: Syndicate, test and fix base64 implementation

serge-sans-paille updated this revision to Diff 246290. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75057/new/ https://reviews.llvm.org/D75057 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp compiler-rt/lib/fuzzer/FuzzerUtil.cpp

[PATCH] D75057: Syndicate, test and fix base64 implementation

serge-sans-paille updated this revision to Diff 246279. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75057/new/ https://reviews.llvm.org/D75057 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp compiler-rt/lib/fuzzer/FuzzerUtil.cpp

[PATCH] D75057: Syndicate, test and fix base64 implementation

serge-sans-paille updated this revision to Diff 246248. serge-sans-paille added a comment. Other copy/paste typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75057/new/ https://reviews.llvm.org/D75057 Files:

[PATCH] D75057: Syndicate, test and fix base64 implementation

serge-sans-paille removed a reviewer: lebedev.ri. serge-sans-paille added a comment. As a side note, pre-reserving the buffer size gives interesting speedup, see http://quick-bench.com/Lp6OwO2etW1YEmJayVWn3U8JDiY Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75057: Syndicate, test and fix base64 implementation

serge-sans-paille updated this revision to Diff 246243. serge-sans-paille added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75057/new/ https://reviews.llvm.org/D75057 Files:

[PATCH] D75057: Syndicate, test and fix base64 implementation

serge-sans-paille updated this revision to Diff 246240. serge-sans-paille added a comment. Restore duplication, fix the bug in two separate locations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75057/new/ https://reviews.llvm.org/D75057 Files:

[PATCH] D75057: Syndicate, test and fix base64 implementation

lebedev.ri requested changes to this revision. lebedev.ri added inline comments. This revision now requires changes to proceed. Comment at: compiler-rt/lib/fuzzer/FuzzerUtil.cpp:14-16 + +#include "llvm/Support/Base64.h" + I don't believe we can do this.

[PATCH] D75057: Syndicate, test and fix base64 implementation

serge-sans-paille created this revision. serge-sans-paille added reviewers: jvikstrom, george.karpenkov. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits, usaxena95, kadircet, arphaman, jkorous, mgorny. Herald added projects: clang, Sanitizers, LLVM. As an answer to