[PATCH] D75125: [Docs][OpenCL] Release 10.0 notes for OpenCL

2020-02-27 Thread Sven van Haastregt via Phabricator via cfe-commits
svenvh closed this revision. svenvh added a comment. Committed in e5cb70267e7 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75125/new/ https://reviews.llvm.org/D75125 _

[PATCH] D75125: [Docs][OpenCL] Release 10.0 notes for OpenCL

2020-02-27 Thread Hans Wennborg via Phabricator via cfe-commits
hans added a comment. In D75125#1895060 , @Anastasia wrote: > @hans, what is the current process for committing to the release branch? > Would you be able to commit this or would you prefer that I commit myself? > > Thank you! You can just push it to th

[PATCH] D75125: [Docs][OpenCL] Release 10.0 notes for OpenCL

2020-02-27 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added a comment. > Thanks for writing notes! Go ahead and push directly to the branch when > you're ready. Sorry. Missed this somehow! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75125/new/ https://reviews.llvm.org/D75125 ___

[PATCH] D75125: [Docs][OpenCL] Release 10.0 notes for OpenCL

2020-02-27 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added a comment. @hans, what is the current process for committing to the release branch? Would you be able to commit this or would you prefer that I commit myself? Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75125/new/ https://reviews.llvm.org/D75125 ___

[PATCH] D75125: [Docs][OpenCL] Release 10.0 notes for OpenCL

2020-02-26 Thread Sven van Haastregt via Phabricator via cfe-commits
svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75125/new/ https://reviews.llvm.org/D75125 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D75125: [Docs][OpenCL] Release 10.0 notes for OpenCL

2020-02-26 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia updated this revision to Diff 246774. Anastasia added a comment. Addressed comments from Hans and Sven. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75125/new/ https://reviews.llvm.org/D75125 Files: clang/docs/ReleaseNotes.rst Index: clang/docs/ReleaseNotes.rst =

[PATCH] D75125: [Docs][OpenCL] Release 10.0 notes for OpenCL

2020-02-26 Thread Sven van Haastregt via Phabricator via cfe-commits
svenvh added inline comments. Comment at: clang/docs/ReleaseNotes.rst:293 +- Allowed ``__private`` to be printed explicitly in diagnostics, AST, etc +- Fixed declaration of ``enqueue_marker``, c11 atomic fetch max/min in the + standard header. Suggesting to mov

[PATCH] D75125: [Docs][OpenCL] Release 10.0 notes for OpenCL

2020-02-26 Thread Hans Wennborg via Phabricator via cfe-commits
hans added a comment. Thanks for writing notes! Go ahead and push directly to the branch when you're ready. Comment at: clang/docs/ReleaseNotes.rst:288 +OpenCL Kernel Language Changes in Clang -- For the formatting to work, I

[PATCH] D75125: [Docs][OpenCL] Release 10.0 notes for OpenCL

2020-02-25 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: clang/docs/ReleaseNotes.rst:305 +- Added support for function attributes. +FIXME: Add a sentence explaining current state? + @svenvh Do you think we should add a sentence to

[PATCH] D75125: [Docs][OpenCL] Release 10.0 notes for OpenCL

2020-02-25 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia created this revision. Anastasia added reviewers: svenvh, AlexeySotkin. Herald added subscribers: ebevhan, jfb, yaxunl. https://reviews.llvm.org/D75125 Files: clang/docs/ReleaseNotes.rst Index: clang/docs/ReleaseNotes.rst =