This revision was automatically updated to reflect the committed changes.
Closed by commit rGddd11273d9d0: Remove BinaryOperator::CreateFNeg (authored by
simoll).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75130/new/
https://reviews.llvm.org/D751
simoll updated this revision to Diff 246974.
simoll added a comment.
- rebased
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75130/new/
https://reviews.llvm.org/D75130
Files:
clang/test/CodeGen/complex-math.c
llvm/include/llvm/IR/InstrTypes.h
cameron.mcinally accepted this revision.
cameron.mcinally added a comment.
This revision is now accepted and ready to land.
LGTM, with the TODO to be handled under a separate patch.
Thank you for taking care of this, Simon.
Comment at: llvm/lib/Transforms/InstCombine/InstCombi
xbolva00 added inline comments.
Comment at: llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp:341
Value *NewSel = Builder.CreateSelect(Cond, X, Y, SI.getName() + ".v", &SI);
// TODO: Remove the hack for the binop form when the unary op is optimized
// pro
simoll marked an inline comment as done.
simoll added inline comments.
Comment at: llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp:341
Value *NewSel = Builder.CreateSelect(Cond, X, Y, SI.getName() + ".v", &SI);
// TODO: Remove the hack for the binop form when the
xbolva00 added inline comments.
Comment at: llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp:341
Value *NewSel = Builder.CreateSelect(Cond, X, Y, SI.getName() + ".v", &SI);
// TODO: Remove the hack for the binop form when the unary op is optimized
// pro
simoll updated this revision to Diff 246544.
simoll added a comment.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
- rebased
- fixed clang complex-math test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75130/new/
https://r
