This revision was automatically updated to reflect the committed changes.
Closed by commit rGd481e59863ac: [hexagon] Add default paths to support musl
target (authored by sidneym).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75139/new/
https://rev
sidneym updated this revision to Diff 247724.
sidneym added a comment.
address clang-tidy issues
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75139/new/
https://reviews.llvm.org/D75139
Files:
clang/lib/Driver/ToolChains/Hexagon.cpp
clang/test
sidneym updated this revision to Diff 247711.
sidneym added a comment.
Update testcase.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75139/new/
https://reviews.llvm.org/D75139
Files:
clang/lib/Driver/ToolChains/Hexagon.cpp
clang/test/Driver/h
This revision was automatically updated to reflect the committed changes.
Closed by commit rG637767665141: Add default paths to support musl target
(authored by sidneym).
Changed prior to commit:
https://reviews.llvm.org/D75139?vs=247251&id=247701#toc
Repository:
rG LLVM Github Monorepo
CHA
sidneym updated this revision to Diff 247251.
sidneym added a comment.
Move selection of the dynamic linker before user args are added.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75139/new/
https://reviews.llvm.org/D75139
Files:
clang/lib/Dri
sidneym marked an inline comment as done.
sidneym added inline comments.
Comment at: clang/lib/Driver/ToolChains/Hexagon.cpp:290
+}
+if (!Args.hasArg(options::OPT_shared))
+ CmdArgs.push_back("-dynamic-linker=/lib/ld-musl-hexagon.so.1");
the default
bcain accepted this revision.
bcain added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: ormris.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75139/new/
https://reviews.llvm.org/D75139
__
sidneym created this revision.
sidneym added reviewers: kparzysz, bcain, adasgupt.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Pickup the default crt and libs when the musl target is selected.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D75139
File