[PATCH] D75194: [clang-format] Do not merge very long C# automatic properties

2020-03-03 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. @krasimir, well I learned something new, so thanks for taking the time to explain that to help improve our understanding. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75194/new/ https://reviews.llvm.org/D75194 _

[PATCH] D75194: [clang-format] Do not merge very long C# automatic properties

2020-03-03 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir added a comment. Here's some empirical ideas about the approach: In clang-format, braces can be handled in two quite distinct ways, controlled by BraceBlockKind : BK_

[PATCH] D75194: [clang-format] Do not merge very long C# automatic properties

2020-03-02 Thread Jonathan B Coe via Phabricator via cfe-commits
jbcoe planned changes to this revision. jbcoe added a comment. I will try to handle this in unwrapped line parser. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75194/new/ https://reviews.llvm.org/D75194 _

[PATCH] D75194: [clang-format] Do not merge very long C# automatic properties

2020-02-28 Thread Jonathan B Coe via Phabricator via cfe-commits
jbcoe marked an inline comment as done. jbcoe added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:489 +// If the Limit is broken, split the default value onto a new line and +// indent it. +// krasimir wrote: > Why not alway

[PATCH] D75194: [clang-format] Do not merge very long C# automatic properties

2020-02-28 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:489 +// If the Limit is broken, split the default value onto a new line and +// indent it. +// Why not always (not just when Limit is broken) merge the whole autom