This revision was automatically updated to reflect the committed changes.
Closed by commit rGc24c89d6f0f5: [clangd] Get rid of unnecessary source
transformations in locateMacroAt (authored by kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
kadircet updated this revision to Diff 247438.
kadircet marked an inline comment as done.
kadircet added a comment.
- Drop semicolon
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75259/new/
https://reviews.llvm.org/D75259
Files:
hokein accepted this revision.
hokein added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/unittests/SourceCodeTests.cpp:440
+TEST(SourceCodeTests, WorksAtBeginOfFile) {
+ Annotations Code("^MACRO;");
+ TestTU TU =
kadircet created this revision.
kadircet added reviewers: sammccall, hokein.
Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay,
ilya-biryukov.
Herald added a project: clang.
All callers are already passing spelling locations to locateMacroAt.
Also there's no point at
