[PATCH] D75271: [analyzer][NFC] Change LangOptions to CheckerManager in the shouldRegister* functions.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbda3dd0d986b: [analyzer][NFC] Change LangOptions to CheckerManager in the shouldRegister*… (authored by Szelethus). Herald added a subscriber: ASDenysPetrov. Changed prior to commit: https://reviews.llv

[PATCH] D75271: [analyzer][NFC] Change LangOptions to CheckerManager in the shouldRegister* functions.

NoQ accepted this revision. NoQ added a comment. Great, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75271/new/ https://reviews.llvm.org/D75271 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[PATCH] D75271: [analyzer][NFC] Change LangOptions to CheckerManager in the shouldRegister* functions.

baloghadamsoftware accepted this revision. baloghadamsoftware added a comment. This revision is now accepted and ready to land. OK, I agree, these issues should be solved in other patches. I already solved one, but the other one is strange. I will open a BugZilla ticket for it. CHANGES SINCE LA

[PATCH] D75271: [analyzer][NFC] Change LangOptions to CheckerManager in the shouldRegister* functions.

Szelethus added a comment. Thanks for bringing it up, I'll attend to it -- though both of those changes are out of scope of this change, and I'd be strongly against solving any of those issues within this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75271/new/ https://revie

[PATCH] D75271: [analyzer][NFC] Change LangOptions to CheckerManager in the shouldRegister* functions.

baloghadamsoftware added a comment. It is even worse: the `shouldRegister()` functions do not prevent the registration of a checker, at least in cases when they are not enabled directly but via dependencies. See D75171 . CHANGES SINCE LAST ACTION https://revi

[PATCH] D75271: [analyzer][NFC] Change LangOptions to CheckerManager in the shouldRegister* functions.

baloghadamsoftware requested changes to this revision. baloghadamsoftware added a comment. This revision now requires changes to proceed. This patch still does not help. Most of the functions of `CheckerManager` are non-const thus they cannot be called on a const object. E.g. `getAnalyzerOptions

[PATCH] D75271: [analyzer][NFC] Change LangOptions to CheckerManager in the shouldRegister* functions.

baloghadamsoftware accepted this revision. baloghadamsoftware added a comment. I think this is straightforward after D75360 . This was my original attempt as well, but without D75360 it did not work. This solves the problem of b

[PATCH] D75271: [analyzer][NFC] Change LangOptions to CheckerManager in the shouldRegister* functions.

Szelethus added a comment. Mind that `AnalysisManager`, similarly to `CheckerManager` before D75360 , must be constructed with an `ASTContext` which is not available at the moment when the `shouldRegister*` functions run, and they must run no later than when the

[PATCH] D75271: [analyzer][NFC] Change LangOptions to CheckerManager in the shouldRegister* functions.

Szelethus updated this revision to Diff 247292. Szelethus retitled this revision from "[Analyzer][NFC] Add AnalyzerOptions parameter to shouldRegisterXXX() functions" to "[analyzer][NFC] Change LangOptions to CheckerManager in the shouldRegister* functions.". Szelethus edited the summary of this