This revision was automatically updated to reflect the committed changes.
Closed by commit rG3302af83ef79: [clangd] Make use of token buffers in semantic
highlighting (authored by kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75447/new/
h
kadircet updated this revision to Diff 247805.
kadircet added a comment.
- Use spelledTokenAt
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75447/new/
https://reviews.llvm.org/D75447
Files:
clang-tools-extra/clangd/SemanticHighlighting.cpp
Ind
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:162
+[&](const syntax::Token &Tok) { return Tok.location() < Loc; });
+assert(Tok);
+
kadircet updated this revision to Diff 247695.
kadircet marked 2 inline comments as done.
kadircet added a comment.
- Address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75447/new/
https://reviews.llvm.org/D75447
Files:
clang-tools-ex
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:134
public:
- HighlightingsBuilder(const SourceManager &SourceMgr,
- const LangOptions &LangOpts)
- : SourceMgr(SourceMgr), LangOpts(LangOpts) {}
+ Highlig
kadircet updated this revision to Diff 247612.
kadircet added a comment.
- Add forgetten macroid check, before looking for an macroargexpansion.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75447/new/
https://reviews.llvm.org/D75447
Files:
clan
kadircet created this revision.
kadircet added reviewers: hokein, sammccall.
Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay,
ilya-biryukov.
Herald added a project: clang.
kadircet added a parent revision: D75446: [clang][Syntax] Handle macro
arguments in spelledForEx
