[PATCH] D75529: [analyzer] Limit UCharMax to min of max uchar or max int

This revision was automatically updated to reflect the committed changes. Closed by commit rG0eba5dc80fb0: [analyzer] Fix modeling some library functions when UCHAR_MAX > INT_MAX. (authored by dergachev.a). Changed prior to commit: https://reviews.llvm.org/D75529?vs=250109&id=250464#toc Reposi

[PATCH] D75529: [analyzer] Limit UCharMax to min of max uchar or max int

NoQ added a comment. In D75529#1921959 , @vabridgers wrote: > @Charusso -- I do not have commit access, but I will request. Thank you. Whoops, i accidentally landed this patch because i misread your statement as if you're asking to land the patch for yo

[PATCH] D75529: [analyzer] Limit UCharMax to min of max uchar or max int

vabridgers marked an inline comment as done. vabridgers added a comment. @Charusso -- I do not have commit access, but I will request. Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75529/new/ https://reviews.llvm.org/D75529 __

[PATCH] D75529: [analyzer] Limit UCharMax to min of max uchar or max int

Charusso added a comment. In D75529#1920796 , @vabridgers wrote: > I believe all comments have been addressed. Please let me know if there's > anything else required. Thanks I think you have solved everything. Do you have commit access? May you would r

[PATCH] D75529: [analyzer] Limit UCharMax to min of max uchar or max int

vabridgers marked 6 inline comments as done. vabridgers added a comment. I believe all comments have been addressed. Please let me know if there's anything else required. Thanks Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:519 + // architecture

[PATCH] D75529: [analyzer] Limit UCharMax to min of max uchar or max int

vabridgers updated this revision to Diff 250109. vabridgers marked 2 inline comments as not done. vabridgers added a comment. fix pre merge checkswq Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75529/new/ https://reviews.llvm.org/D75529 Files:

[PATCH] D75529: [analyzer] Limit UCharMax to min of max uchar or max int

vabridgers updated this revision to Diff 249680. vabridgers added a comment. Address Artem's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75529/new/ https://reviews.llvm.org/D75529 Files: clang/lib/StaticAnalyzer/Checkers/StdLibraryFu

[PATCH] D75529: [analyzer] Limit UCharMax to min of max uchar or max int

Szelethus accepted this revision. Szelethus added a comment. I have nothing else to add :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75529/new/ https://reviews.llvm.org/D75529 ___ cfe-commits maili

[PATCH] D75529: [analyzer] Limit UCharMax to min of max uchar or max int

NoQ added a comment. Aha, ok, i appreciate making life easier for downstream users. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:519 + // architectures, but not for others. + const RangeInt UCharMax = + std::min(BVF.getMaxValue(ACtx.Unsig

[PATCH] D75529: [analyzer] Limit UCharMax to min of max uchar or max int

Charusso accepted this revision. Charusso added a comment. In D75529#1912849 , @vabridgers wrote: > @Charusso, I cannot find a way to create a test for this change, since this > was found using an architecture that supports 16-bit chars. I really felt t

[PATCH] D75529: [analyzer] Limit UCharMax to min of max uchar or max int

vabridgers added a comment. Herald added a subscriber: danielkiss. @Charusso, I cannot find a way to create a test for this change, since this was found using an architecture that supports 16-bit chars. I understand the need to create test cases for changes. In this case, I believe a rationale f

[PATCH] D75529: [analyzer] Limit UCharMax to min of max uchar or max int

vabridgers updated this revision to Diff 247936. vabridgers added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75529/new/ https://reviews.llvm.org/D75529 Files: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunc

[PATCH] D75529: [analyzer] Limit UCharMax to min of max uchar or max int

vabridgers marked 2 inline comments as done. vabridgers added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:514 + // Set UCharMax to min of int or uchar maximum value. + // The C standard states that functions like isalpha must be

[PATCH] D75529: [analyzer] Limit UCharMax to min of max uchar or max int

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Looks good to me! Thanks! Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:514 + // Set UCharMax to min of int or uchar maximum value. + // Th

[PATCH] D75529: [analyzer] Limit UCharMax to min of max uchar or max int

Charusso added a comment. Could you add a test please? We really need tests for every patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75529/new/ https://reviews.llvm.org/D75529 ___ cfe-commits mai

[PATCH] D75529: [analyzer] Limit UCharMax to min of max uchar or max int

vabridgers created this revision. vabridgers added reviewers: martong, Szelethus, NoQ. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, kristof.beyls, xazax.hun. Herald added a project: clang. This change is a follow up to commit 5