This revision was automatically updated to reflect the committed changes.
Closed by commit rGfa8080376e73: [AST][SVE] Add new Type queries for sizeless
types (authored by rsandifo-arm).
Changed prior to commit:
https://reviews.llvm.org/D75570?vs=248125=249961#toc
Repository:
rG LLVM Github
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75570/new/
https://reviews.llvm.org/D75570
rsandifo-arm added a comment.
Herald added a subscriber: danielkiss.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75570/new/
https://reviews.llvm.org/D75570
___
cfe-commits mailing list
rsandifo-arm updated this revision to Diff 248125.
rsandifo-arm added a comment.
Run git-clang-format.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75570/new/
https://reviews.llvm.org/D75570
Files:
clang/include/clang/AST/CanonicalType.h
rsandifo-arm added a comment.
At the moment the queries just return true for SVE types, so an obvious
alternative would be to check specifically for SVE types. The sizeless type
concept is more general than that though. E.g. my understanding from:
rsandifo-arm created this revision.
rsandifo-arm added reviewers: sdesmalen, efriedma, rovka, rjmccall.
Herald added subscribers: cfe-commits, psnobl, rkruppe, kristof.beyls,
tschuett, mgorny.
Herald added a reviewer: rengolin.
Herald added a project: clang.
rsandifo-arm added a comment.