[PATCH] D75643: [Sema] Don't emit pointer to int cast warnings under -Wmicrosoft-cast

2020-03-09 Thread Arthur Eubanks via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG51d7f645448b: Don't emit pointer to int cast warnings under -Wmicrosoft-cast (authored by aeubanks). Changed prior to commit: https://reviews.llvm.org/D75643?vs=248306&id=249203#toc Repository: rG LL

[PATCH] D75643: [Sema] Don't emit pointer to int cast warnings under -Wmicrosoft-cast

2020-03-09 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. I think I patched this in, ran tests, but didn't push. Feel free to push if you get the chance. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75643/new/ https://reviews.llvm.org/D75643 __

[PATCH] D75643: [Sema] Don't emit pointer to int cast warnings under -Wmicrosoft-cast

2020-03-06 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. I re-read Richard's comment: > Would it make sense to put the MS extension warning into the > -Wpointer-to-int-cast group so that we can control this warning consistently > across platforms? You co

[PATCH] D75643: [Sema] Don't emit pointer to int cast warnings under -Wmicrosoft-cast

2020-03-04 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a subscriber: rsmith. rnk added a comment. Looking at the review, I think @rsmith requested this -Wmicrosoft-cast behavior here: https://reviews.llvm.org/D72231#1857660 This change looks good to me, but I wanted to get his input before we undo his request. Repository: rG LLVM Gith