[PATCH] D75655: [Docs] Document -lto-whole-program-visibility

This revision was automatically updated to reflect the committed changes. Closed by commit rG72bdb41a06a2: [Docs] Document --lto-whole-program-visibility (authored by tejohnson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75655/new/

[PATCH] D75655: [Docs] Document -lto-whole-program-visibility

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM Thanks and sorry for the delay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75655/new/ https://reviews.llvm.org/D75655

[PATCH] D75655: [Docs] Document -lto-whole-program-visibility

tejohnson updated this revision to Diff 287808. tejohnson marked an inline comment as done. tejohnson added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75655/new/ https://reviews.llvm.org/D75655 Files:

[PATCH] D75655: [Docs] Document -lto-whole-program-visibility

tejohnson marked an inline comment as done. tejohnson added a comment. In D75655#2237474 , @pcc wrote: > I think that the part of the description beginning "This can be used when..." > is somewhat misleading since you could pretty much say the same thing

[PATCH] D75655: [Docs] Document -lto-whole-program-visibility

pcc added a comment. I think that the part of the description beginning "This can be used when..." is somewhat misleading since you could pretty much say the same thing about specifying `-fvisibility=hidden -fwhole-program-vtables` at compile time. I think it would be better to focus on the

[PATCH] D75655: [Docs] Document -lto-whole-program-visibility

MaskRay added inline comments. Comment at: clang/docs/LTOVisibility.rst:39 +During the LTO link, all classes with public LTO visibility will be refined +to hidden LTO visibility when the ``-lto-whole-program-visibility`` lld linker +option is applied

[PATCH] D75655: [Docs] Document -lto-whole-program-visibility

tejohnson added a comment. @pcc ping. I'd like to get something in for LLVM 11 if at all possible. How about for now I make the last sentence something like "This is useful in situations where it is not safe to specify``-fvisibility=hidden`` at compile time, for example when bitcode objects

[PATCH] D75655: [Docs] Document -lto-whole-program-visibility

tejohnson added a comment. In D75655#1920036 , @evgeny777 wrote: > @pcc > > > That case seems somewhat questionable to me. If the symbols are being > > exported, it is presumably for the purpose of allowing the symbols to be > > used outside of the

[PATCH] D75655: [Docs] Document -lto-whole-program-visibility

evgeny777 added a comment. @pcc > That case seems somewhat questionable to me. If the symbols are being > exported, it is presumably for the purpose of allowing the symbols to be used > outside of the defining DSO. But LTO visibility based optimizations could > make any such use of the

[PATCH] D75655: [Docs] Document -lto-whole-program-visibility

pcc added inline comments. Comment at: clang/docs/LTOVisibility.rst:45 +build system, and the binary will not dlopen any libraries deriving from the +binary’s classes. This is useful in situations where it is not safe to specify +``-fvisibility=hidden`` at compile time.

[PATCH] D75655: [Docs] Document -lto-whole-program-visibility

tejohnson added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75655/new/ https://reviews.llvm.org/D75655 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D75655: [Docs] Document -lto-whole-program-visibility

tejohnson updated this revision to Diff 248582. tejohnson marked an inline comment as done. tejohnson added a comment. Fix gold plugin option Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75655/new/ https://reviews.llvm.org/D75655 Files:

[PATCH] D75655: [Docs] Document -lto-whole-program-visibility

tejohnson marked 3 inline comments as done. tejohnson added a subscriber: evgeny777. tejohnson added inline comments. Comment at: clang/docs/LTOVisibility.rst:40 +to hidden LTO visibility when the ``-lto-whole-program-visibility`` lld linker +option is applied

[PATCH] D75655: [Docs] Document -lto-whole-program-visibility

pcc added inline comments. Comment at: clang/docs/LTOVisibility.rst:40 +to hidden LTO visibility when the ``-lto-whole-program-visibility`` lld linker +option is applied (``-plugin-opt=whole_program_visibility`` for gold). This +can be used when it is known that the LTO link has

[PATCH] D75655: [Docs] Document -lto-whole-program-visibility

tejohnson created this revision. tejohnson added a reviewer: pcc. Herald added subscribers: dexonsmith, steven_wu, hiraditya, inglorion. Herald added a project: clang. Documents interaction of linker option added in D71913 with LTO visibility. Repository: rG