jdoerfert added inline comments.
Comment at: clang/lib/Headers/CMakeLists.txt:145
set(openmp_wrapper_files
openmp_wrappers/math.h
chapuni wrote:
> It doesn't contain , intentional?
We don't wrap that yet. Do you need it?
Repository:
rG LLVM Github Monor
chapuni added inline comments.
Herald added subscribers: kosarev, mattd, asavonic, sstefan1, MaskRay.
Herald added a project: All.
Comment at: clang/lib/Headers/CMakeLists.txt:145
set(openmp_wrapper_files
openmp_wrappers/math.h
It doesn't contain , intentio
jdoerfert marked an inline comment as done.
jdoerfert added inline comments.
Comment at: clang/test/Headers/nvptx_device_math_macro.cpp:11
+ double a(0);
+// CHECK-NOT: call
+// CHECK: call double @llvm.fabs.f64(double
sammccall wrote:
> Hmm, this fails if the
sammccall added inline comments.
Comment at: clang/test/Headers/nvptx_device_math_macro.cpp:11
+ double a(0);
+// CHECK-NOT: call
+// CHECK: call double @llvm.fabs.f64(double
Hmm, this fails if the test is run from a directory containing "call".
> ; ModuleID
This revision was automatically updated to reflect the committed changes.
Closed by commit rGf85ae058f580: [OpenMP] Provide math functions in OpenMP
device code via OpenMP variants (authored by jdoerfert).
Changed prior to commit:
https://reviews.llvm.org/D75788?vs=255050&id=255897#toc
Reposit
jdoerfert updated this revision to Diff 255050.
jdoerfert added a comment.
Cleanup and rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75788/new/
https://reviews.llvm.org/D75788
Files:
clang/lib/Driver/ToolChains/Clang.cpp
clang/lib/Heade
ye-luo added a comment.
My RHEL issue was caused by a CPLUS_INCLUDE_PATH environment variable. So this
is feature not a bug. After removing it, everything works smoothly for me.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75788/new/
https://revi
ye-luo accepted this revision.
ye-luo added a comment.
This revision is now accepted and ready to land.
Good work.
I verified that PR42798 and PR42799 are fixed by this.
Tests are completed on Ubuntu 18.04.
Clang now becomes usable for application developers.
There are still issues on RHEL that o
jdoerfert updated this revision to Diff 254375.
jdoerfert added a comment.
Herald added a subscriber: yaxunl.
Rewrite. Wrap math.h, time.h, and cmath. Preload only device functions.
Passes all 185 math c++11 tests from [0] which do not deal with long double.
[0] https://github.com/TApplencourt/Om
jdoerfert updated this revision to Diff 253154.
jdoerfert added a comment.
Remove OpenMP from clang/lib/Headers/__clang_cuda_math_forward_declares.h
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75788/new/
https://reviews.llvm.org/D75788
Files:
jdoerfert updated this revision to Diff 253153.
jdoerfert added a comment.
Add and repair tests to show new features, e.g. math macro support
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75788/new/
https://reviews.llvm.org/D75788
Files:
clang/l
11 matches
Mail list logo