[PATCH] D76297: [clang][AArch64] readd support for 'p' inline asm constraint

This revision was automatically updated to reflect the committed changes. Closed by commit rG5d90f886bc02: [clang][AArch64] readd support for 'p' inline asm constraint (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76297

[PATCH] D76297: [clang][AArch64] readd support for 'p' inline asm constraint

sdesmalen accepted this revision. sdesmalen added a comment. In D76297#1927053 , @nickdesaulniers wrote: > @sdesmalen sorry, would you mind re-reviewing. I'm not comfortable landing > with the previous version being reviewed and not the current one. Su

[PATCH] D76297: [clang][AArch64] readd support for 'p' inline asm constraint

echristo added inline comments. Comment at: clang/test/CodeGen/inline-asm-p-constraint.c:1 +// RUN: %clang_cc1 -emit-llvm %s -o - -triple aarch64-linux-gnu | FileCheck %s +void foo(void* ptr) { nickdesaulniers wrote: > Does this need `REQUIRES: aarch64-registered

[PATCH] D76297: [clang][AArch64] readd support for 'p' inline asm constraint

nickdesaulniers added inline comments. Comment at: clang/test/CodeGen/inline-asm-p-constraint.c:1 +// RUN: %clang_cc1 -emit-llvm %s -o - -triple aarch64-linux-gnu | FileCheck %s +void foo(void* ptr) { Does this need `REQUIRES: aarch64-registered-target`? Reposi

[PATCH] D76297: [clang][AArch64] readd support for 'p' inline asm constraint

nickdesaulniers added a comment. @sdesmalen sorry, would you mind re-reviewing. I'm not comfortable landing with the previous version being reviewed and not the current one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76297/new/ https://reviews.

[PATCH] D76297: [clang][AArch64] readd support for 'p' inline asm constraint

nickdesaulniers updated this revision to Diff 250812. nickdesaulniers added a comment. - fix 'U' case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76297/new/ https://reviews.llvm.org/D76297 Files: clang/lib/Basic/Targets/AArch64.h clang/test/

[PATCH] D76297: [clang][AArch64] readd support for 'p' inline asm constraint

nickdesaulniers marked an inline comment as done. nickdesaulniers added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.h:98 break; -default: - R = std::string(1, *Constraint); - break; } +return TargetInfo::convertConstraint(Constraint)

[PATCH] D76297: [clang][AArch64] readd support for 'p' inline asm constraint

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/Basic/Targets/AArch64.h:97 Constraint += 2; break; } nit: does this need a `default: break`? Repositor

[PATCH] D76297: [clang][AArch64] readd support for 'p' inline asm constraint

nickdesaulniers created this revision. nickdesaulniers added a reviewer: eli.friedman. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. nickdesaulniers marked an inline comment as done. sdesmalen accepted this revision. sdesmalen added a comment. This revision is