[PATCH] D76389: [NewPM] Run the Speculative Execution Pass only if the target has divergent branches

leonardchan abandoned this revision. leonardchan added a comment. In D76389#2120868 , @arsenm wrote: > This seems like it covers a different case than D82735 > ? I haven't rebased in a while, but D82735

[PATCH] D76389: [NewPM] Run the Speculative Execution Pass only if the target has divergent branches

arsenm added a comment. This seems like it covers a different case than D82735 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76389/new/ https://reviews.llvm.org/D76389 _

[PATCH] D76389: [NewPM] Run the Speculative Execution Pass only if the target has divergent branches

leonardchan updated this revision to Diff 257800. leonardchan marked an inline comment as done. leonardchan edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76389/new/ https://reviews.llvm.org/D76389 Files: llvm/l

[PATCH] D76389: [NewPM] Run the Speculative Execution Pass only if the target has divergent branches

arsenm added inline comments. Comment at: llvm/include/llvm/Transforms/Scalar/SpeculativeExecution.h:97 + +class SpeculativeExecutionIfHasBranchDivergencePass +: public SpeculativeExecutionPassImpl, Still define a second pass Comment at: ll

[PATCH] D76389: [NewPM] Run the Speculative Execution Pass only if the target has divergent branches

leonardchan marked an inline comment as done. leonardchan added inline comments. Comment at: llvm/lib/Passes/PassBuilder.cpp:435 if (Level.getSpeedupLevel() > 1) { -FPM.addPass(SpeculativeExecutionPass()); +FPM.addPass(SpeculativeExecutionIfHasBranchDivergencePass());

[PATCH] D76389: [NewPM] Run the Speculative Execution Pass only if the target has divergent branches

leonardchan updated this revision to Diff 255474. leonardchan edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76389/new/ https://reviews.llvm.org/D76389 Files: llvm/include/llvm/Transforms/Scalar/SpeculativeExecu

[PATCH] D76389: [NewPM] Run the Speculative Execution Pass only if the target has divergent branches

arsenm added inline comments. Comment at: clang/test/CodeGen/thinlto-distributed-newpm.ll:110 ; CHECK-O: Running analysis: OuterAnalysisManagerProxy -; CHECK-O: Running pass: SpeculativeExecutionPass on main +; CHECK-O: Running pass: SpeculativeExecutionIfHasBranchDivergencePass

[PATCH] D76389: [NewPM] Run the Speculative Execution Pass only if the target has divergent branches

leonardchan added a comment. In D76389#1951135 , @arsenm wrote: > Commit message should say only if? Updated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76389/new/ https://reviews.llvm.org/D76389 ___