wchilders abandoned this revision.
wchilders added a comment.
Abandoned in favor of https://reviews.llvm.org/D76420
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76443/new/
https://reviews.llvm.org/D76443
___
cfe-commits mailing list
cfe-co
wchilders updated this revision to Diff 252610.
wchilders added a comment.
Updated to remove duplicated (and out dated) APValue generation logic, and
fixed formatting issues. (Thanks for pointing out something was awry Tyker)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76443/new/
htt
Tyker added inline comments.
Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1871
+llvm::Constant *CodeGenModule::EmitConstantValue(const APValue &Value,
+ QualType DestType,
+ CodeGe
wchilders added inline comments.
Comment at: clang/lib/CodeGen/CGStmt.cpp:1095
+// preventing the cached results from being used.
+if (!isa(fe)) {
+ enterFullExpression(fe);
This one is a bit weird, I think the comment explains it well, but I feel th
wchilders created this revision.
wchilders added reviewers: void, Tyker, rsmith.
Herald added subscribers: cfe-commits, jfb.
Herald added a project: clang.
wchilders added inline comments.
Comment at: clang/lib/CodeGen/CGStmt.cpp:1095
+// preventing the cached results from be
