bcain accepted this revision.
bcain added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76546/new/
https://reviews.llvm.org/D76546
___
c
This revision was automatically updated to reflect the committed changes.
Closed by commit rG81194bfeea7b: [Hexagon] MaxAtomicPromoteWidth and
MaxAtomicInlineWidth are not getting set. (authored by sidneym).
Changed prior to commit:
https://reviews.llvm.org/D76546?vs=251896&id=253640#toc
Repos
sidneym created this revision.
sidneym added reviewers: kparzysz, adasgupt, bcain.
Herald added subscribers: cfe-commits, jfb.
Herald added a project: clang.
Seeing errors while building the c++ library:
atomic:2756:16: error: use of undeclared identifier '__libcpp_signed_lock_free'
typedef ato
sidneym marked an inline comment as done.
sidneym added inline comments.
Comment at: clang/test/Preprocessor/hexagon-predefines.c:117
+
+
+// RUN: %clang_cc1 -E -dM -triple hexagon-unknown-linux-musl \
The extra line break?
Repository:
rG LLVM Github Monorepo
sidneym updated this revision to Diff 251896.
sidneym added a comment.
remove extra line break.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76546/new/
https://reviews.llvm.org/D76546
Files:
clang/lib/Basic/Targets/Hexagon.h
clang/test/Prepro