[PATCH] D76594: [clang][AST] Support AST files larger than 512M

DmitryPolukhin added inline comments. Comment at: clang/lib/Serialization/ASTWriter.cpp:1908 +uint64_t Offset = Stream.GetCurrentBitNo() - SLocEntryOffsetsBase; +assert((Offset >> 32) == 0 && "SLocEntry offset too large"); +SLocEntryOffsets.push_back(Offset);

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

JackKemp99 added inline comments. Comment at: clang/lib/Serialization/ASTWriter.cpp:1908 +uint64_t Offset = Stream.GetCurrentBitNo() - SLocEntryOffsetsBase; +assert((Offset >> 32) == 0 && "SLocEntry offset too large"); +SLocEntryOffsets.push_back(Offset);

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

This revision was automatically updated to reflect the committed changes. Closed by commit rGa7afb211dc46: [clang][AST] Support AST files larger than 512M (authored by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76594/new/ https:/

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

DmitryPolukhin updated this revision to Diff 258192. DmitryPolukhin marked 3 inline comments as done. DmitryPolukhin added a comment. Comments resolved Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76594/new/ https://reviews.llvm.org/D76594 Files:

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

DmitryPolukhin added inline comments. Comment at: clang/include/clang/Serialization/ASTBitCodes.h:228 + /// value in the padding affects AST hash. + uint32_t BitOffsetLow = 0; + uint32_t BitOffsetHigh = 0; sammccall wrote: > consider making this a

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

sammccall accepted this revision. sammccall added a comment. A little sad it's not possible to just 64-bit align the typeoffsets array, but 32 seems to be the magic number. Comment at: clang/include/clang/Serialization/ASTBitCodes.h:225 + /// Offset in the AST file. Split

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

DmitryPolukhin updated this revision to Diff 258088. DmitryPolukhin added a comment. Split TypeOffsets to low/high parts too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76594/new/ https://reviews.llvm.org/D76594 Files: clang/include/clang/Seri

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

DmitryPolukhin added a comment. In D76594#1986846 , @martong wrote: > I am not sure, but maybe this patch causes an undefined behavior? > > http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/40472/steps/check-clang%20ubsan/logs/stdio >

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

martong added a comment. I am not sure, but maybe this patch causes an undefined behavior? http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/40472/steps/check-clang%20ubsan/logs/stdio /b/sanitizer-x86_64-linux-fast/build/llvm-project/clang/lib/Serialization/ASTReader.cpp:632

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

This revision was automatically updated to reflect the committed changes. Closed by commit rG30d5946db95f: [clang][AST] Support AST files larger than 512M (authored by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76594/new/ https:/

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

DmitryPolukhin updated this revision to Diff 257635. DmitryPolukhin added a comment. Fix nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76594/new/ https://reviews.llvm.org/D76594 Files: clang/include/clang/Serialization/ASTBitCodes.h clang/

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

DmitryPolukhin marked an inline comment as done. DmitryPolukhin added a comment. @sammccall thank you for review! I'll wait for one more day for additional feedback if any, and land this diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76594/new/

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

DmitryPolukhin updated this revision to Diff 257632. DmitryPolukhin added a comment. Split BitOffset in DeclOffset in high/low parts; rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76594/new/ https://reviews.llvm.org/D76594 Files: clang/in

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

DmitryPolukhin updated this revision to Diff 257633. DmitryPolukhin added a comment. Split BitOffset in DeclOffset in high/low parts; rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76594/new/ https://reviews.llvm.org/D76594 Files: clang/in

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. We're starting to see quite a lot of production crashes with this and would very much like a fix. At this point it seems like we're best moving ahead and if someone comes up with a bette

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

hokein added a comment. I'm not familiar with the code, but this patch does fix the large-preamble crashes we encountered internally. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76594/new/ https://reviews.llvm.org/D76594 _

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

dexonsmith resigned from this revision. dexonsmith added a reviewer: Bigcheese. dexonsmith added a subscriber: Bigcheese. dexonsmith added a comment. Herald added a subscriber: dexonsmith. In D76594#1957452 , @DmitryPolukhin wrote: > @rsmith, @dexonsmit

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

DmitryPolukhin added a comment. @rsmith, @dexonsmith, @jdoerfert could you please take a look to this diff? If you think that there are other reviewers who might have more context AST persistence, please add them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

DmitryPolukhin marked an inline comment as done. DmitryPolukhin added inline comments. Comment at: clang/include/clang/Serialization/ASTBitCodes.h:220 /// Source range/offset of a preprocessed entity. struct DeclOffset { + /// Raw source location. The unsigned i.e.

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

sammccall added inline comments. Comment at: clang/include/clang/Serialization/ASTBitCodes.h:220 /// Source range/offset of a preprocessed entity. struct DeclOffset { + /// Raw source location. The unsigned i.e. 32-bit integer is enough for Is ther

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

DmitryPolukhin updated this revision to Diff 253417. DmitryPolukhin added a comment. Rebase, all tests passes locally Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76594/new/ https://reviews.llvm.org/D76594 Files: clang/include/clang/Serializati

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

DmitryPolukhin updated this revision to Diff 253368. DmitryPolukhin added a comment. Resolve merge conflict, revert clang-format for ASTBitCodes.h to avoid further conflicts, use C++ cast Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76594/new/ ht

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

xbolva00 added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:3100 } - F.TypeOffsets = (const uint32_t *)Blob.data(); + F.TypeOffsets = (const uint64_t *)Blob.data(); F.LocalNumTypes = Record[0]; use C++ cast style Re