[PATCH] D76741: [clangd] Support multiple cursors in selectionRange.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8f237f9b09aa: [clangd] Support multiple cursors in selectionRange. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76741/new/

[PATCH] D76741: [clangd] Support multiple cursors in selectionRange.

usaxena95 accepted this revision. usaxena95 added a comment. This revision is now accepted and ready to land. Thanks. LG. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76741/new/ https://reviews.llvm.org/D76741

[PATCH] D76741: [clangd] Support multiple cursors in selectionRange.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1194-1201 if (Params.positions.size() != 1) { elog("{0} positions provided to SelectionRange. Supports exactly one " "position.", Params.positions.size());

[PATCH] D76741: [clangd] Support multiple cursors in selectionRange.

sammccall updated this revision to Diff 252545. sammccall marked 8 inline comments as done. sammccall added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76741/new/ https://reviews.llvm.org/D76741 Files:

[PATCH] D76741: [clangd] Support multiple cursors in selectionRange.

usaxena95 added a comment. Mostly looks good. Few nits. Thanks. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1194-1201 if (Params.positions.size() != 1) { elog("{0} positions provided to SelectionRange. Supports exactly one " "position.",

[PATCH] D76741: [clangd] Support multiple cursors in selectionRange.

sammccall created this revision. sammccall added a reviewer: usaxena95. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. One change: because there's no way to signal failure individually for each cursor, we now "succeed"