[PATCH] D76761: [clang-tidy] Fix crash in readability-redundant-string-cstr

This revision was automatically updated to reflect the committed changes. Closed by commit rG3807079d705f: [clang-tidy] Fix crash in readability-redundant-string-cstr (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76761/new/

[PATCH] D76761: [clang-tidy] Fix crash in readability-redundant-string-cstr

njames93 updated this revision to Diff 252646. njames93 added a comment. - Fixed by replacing cumbersome code with the arguably proper solution Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76761/new/ https://reviews.llvm.org/D76761 Files:

[PATCH] D76761: [clang-tidy] Fix crash in readability-redundant-string-cstr

njames93 added a comment. In D76761#1941476 , @gribozavr2 wrote: > Right -- what I meant is a more detailed description of why, for example, > `tryGetCallExprAncestorForCxxConstructExpr` can't find the `CallExpr` in this > case -- is it not there, or

[PATCH] D76761: [clang-tidy] Fix crash in readability-redundant-string-cstr

gribozavr2 added a comment. In D76761#1941380 , @njames93 wrote: > In D76761#1941070 , @gribozavr2 > wrote: > > > Could you provide more information about why these null checks are needed > > in this case? > > >

[PATCH] D76761: [clang-tidy] Fix crash in readability-redundant-string-cstr

njames93 added a comment. In D76761#1941070 , @gribozavr2 wrote: > Could you provide more information about why these null checks are needed in > this case? Well the fact it was crashing without those null checks was the reason they were added. I'm

[PATCH] D76761: [clang-tidy] Fix crash in readability-redundant-string-cstr

gribozavr2 added a comment. Could you provide more information about why these null checks are needed in this case? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76761/new/ https://reviews.llvm.org/D76761

[PATCH] D76761: [clang-tidy] Fix crash in readability-redundant-string-cstr

njames93 created this revision. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D76761 Files: clang-tools-extra/clang-tidy/readability/RedundantStringCStrCheck.cpp