[PATCH] D76764: [AST] Build recovery expressions for nonexistent member exprs.

2020-03-26 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa9ab11d40830: [AST] Build recovery expressions for nonexistent member exprs. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76764/new/

[PATCH] D76764: [AST] Build recovery expressions for nonexistent member exprs.

2020-03-25 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 252559. hokein marked an inline comment as done. hokein added a comment. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous. address comment and fix a failing testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76764: [AST] Build recovery expressions for nonexistent member exprs.

2020-03-25 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice! Comment at: clang/lib/Parse/ParseExpr.cpp:2107 + } else if (OrigLHS && Name.isValid()) { +// Preserve the member expr if the LHS is an invalid

[PATCH] D76764: [AST] Build recovery expressions for nonexistent member exprs.

2020-03-25 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. Previously, we dropped the AST node for nonexistent member exprs. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D76764 Files: clang/lib/Parse/ParseExpr.cpp